Repository navigation
Conversation
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
fd3fc6c to
0679364
Compare
1fbf61d to
dcbe4c5
Compare
relates to STACKITCLI-441
relates to STACKITCLI-441
Co-authored-by: Alexander Dahmen <alexander.dahmen@inovex.de>
relates to STACKITCLI-441
Co-authored-by: Jonas Schlecht <73650029+SerseusWasTaken@users.noreply.github.com>
relates to STACKITCLI-441
relates to STACKITCLI-441
145a0ef to
3e21af0
Compare
| // Truncate output | ||
| if model.Limit != nil && len(storages) > int(*model.Limit) { | ||
| storages = storages[:*model.Limit] | ||
| } |
There was a problem hiding this comment.
we should truncate the list before outputResult is called, right? otherwise only the table output works with truncation
There was a problem hiding this comment.
I think we do not even need this truncate for this command.
I added it in here, as I am not truncating the list, but a field in the passed resp.
Co-authored-by: Jonas Schlecht <73650029+SerseusWasTaken@users.noreply.github.com>
Merging this branch changes the coverage (5 decrease, 11 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
Description
relates to STACKITCLI-441
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)