Skip to content

Fix Pulp templating issues - #2691

Merged
Alex-Welsh merged 3 commits into
stackhpc/2026.1from
fix-pulp-repo-version-keys
Oct 22, 2026
Merged

Alex-Welsh merged 3 commits into
stackhpc/2026.1from
fix-pulp-repo-version-keys

Conversation

@Alex-Welsh

Copy link
Copy Markdown
Member

Two fixes:
The first renames some version variables so the match what we have in release train. They weren't syncing properly but should be fine now
The second adds some missing third-party rocky repos to pulp.yml, for local image builds from release train repos

@Alex-Welsh
Alex-Welsh requested a review from a team as a code owner October 16, 2026 14:59
@github-actions github-actions Bot added the waiting-review PR is waiting for a review label Oct 16, 2026
@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

The change updates Pulp version keys and Ubuntu Noble repository mappings. It also adds RPM repository definitions for EL 10 container-build syncing, with specified sync and architecture conditions.

Changes: Pulp repository configuration

Layer / File(s) Summary
Ubuntu Pulp version variables and URLs
etc/kayobe/pulp-repo-versions.yml, etc/kayobe/pulp.yml
The version manifest removes Grafana APT and OpenSearch APT/YUM keys, adds Ubuntu Noble Fluentd, Grafana and OpenSearch keys, and renames the Ubuntu Noble ProxySQL key. Ubuntu Noble repository URLs now use the updated variables.
Environment version mappings
etc/kayobe/environments/aio/release-train.yml, etc/kayobe/environments/ci-builder/stackhpc-ci.yml, etc/kayobe/environments/ci-multinode/stackhpc-ci.yml
The environment configurations use Ubuntu Noble Pulp variables for the specified APT, Fluentd and ProxySQL mappings. Existing YUM mappings remain unchanged.
RPM repository definitions
etc/kayobe/pulp.yml
RPM repositories are added for Fluentd, Grafana, OpenSearch, OpenSearch Dashboards, ProxySQL and RabbitMQ. The definitions include sync and, where specified, architecture conditions.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~12 minutes

Merge Risk: 🟡 Moderate · up to cffa0

The release-train environments may use different Grafana and Fluentd repositories than intended. Select their declared release versions before merging.

Pre-merge checks: Passed 3
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (5 skipped: 5 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Alex-Welsh
Alex-Welsh force-pushed the fix-pulp-repo-version-keys branch from 06ebdbe to cffa0fc Compare October 16, 2026 15:01

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration
  • Configuration used: Repository: stackhpc/stackhpc-kayobe-config/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7aa8e3a8-0835-4864-afdb-1a109f0116e5
📥 Commits

Reviewing files that changed from the base of the PR and between fe4e839 and cffa0fc.

📒 Files selected for processing: 5
  • etc/kayobe/environments/aio/release-train.yml
  • etc/kayobe/environments/ci-builder/stackhpc-ci.yml
  • etc/kayobe/environments/ci-multinode/stackhpc-ci.yml
  • etc/kayobe/pulp-repo-versions.yml
  • etc/kayobe/pulp.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Comment thread etc/kayobe/environments/aio/release-train.yml
@Alex-Welsh
Alex-Welsh force-pushed the fix-pulp-repo-version-keys branch from cffa0fc to cb3d442 Compare October 20, 2026 08:33
MoteHue
MoteHue previously approved these changes Oct 21, 2026
When I added package repos in 2026.1, I forgot that they need to match names
used in stackhpc-release-train to ensure they are updated correctly.

This PR fixes that, by renaming the affected repos:
* grafana_apt -> ubuntu_noble_grafana
* opensearch_3_x_apt -> ubuntu_noble_opensearch
* opensearch_dashboards_3_x_apt -> ubuntu_noble_opensearch_dashboards
* opensearch_3_x_yum -> opensearch_3_x
* opensearch_dashboards_3_x_yum -> opensearch_dashboards_3_x
* ubuntu_noble_fluent_6 -> ubuntu_noble_fluentd
* ubuntu_noble_proxysql_3_0 -> ubuntu_noble_proxysql
Adding missing repos for local container image builds

* Fluentd LTS 6 for RHEL 10 (x86_64 and aarch64)
* Grafana
* OpenSearch 3.x
* OpenSearch Dashboards 3.x
* ProxySQL 3.0 for AlmaLinux 10
* RabbitMQ Erlang and server for RHEL 9
@Alex-Welsh
Alex-Welsh force-pushed the fix-pulp-repo-version-keys branch from b880566 to d7f999d Compare October 22, 2026 08:26
@Alex-Welsh
Alex-Welsh merged commit 915c208 into stackhpc/2026.1 Oct 22, 2026
27 of 28 checks passed
@Alex-Welsh
Alex-Welsh deleted the fix-pulp-repo-version-keys branch October 22, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-review PR is waiting for a review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants