Skip to content

feat: disable deployments on workflows - #2689

Open
jackhodgkiss wants to merge 1 commit into
stackhpc/2026.1from
disable-deployments
Open

jackhodgkiss wants to merge 1 commit into
stackhpc/2026.1from
disable-deployments

Conversation

@jackhodgkiss

Copy link
Copy Markdown
Contributor

When using environments in workflows they get treated as a deployment which in unnecessary and leads to a trail of events associated with a given PR.

See: https://docs.github.com/en/actions/how-tos/deploy/configure-and-manage-deployments/control-deployments#using-environments-without-deployments

@jackhodgkiss
jackhodgkiss requested a review from a team as a code owner October 16, 2026 13:00
@github-actions github-actions Bot added the waiting-review PR is waiting for a review label Oct 16, 2026
@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: stackhpc/stackhpc-kayobe-config/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 422e6341-0c47-467a-a2e2-2d6bc7783c48
📥 Commits

Reviewing files that changed from the base of the PR and between 26d7d4b and 8b894c3.

📒 Files selected for processing: 6
  • .github/workflows/amphora-image-build.yml
  • .github/workflows/ipa-image-build.yml
  • .github/workflows/overcloud-host-image-build.yml
  • .github/workflows/package-build-ofed.yml
  • .github/workflows/runner-selector.yml
  • .github/workflows/stackhpc-all-in-one.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Six GitHub Actions jobs now configure their environments with a mapping. Each mapping retains the existing environment name and sets deployment to false.

Changes: Workflow environment configuration

Layer / File(s) Summary
Job environment mappings
.github/workflows/runner-selector.yml, .github/workflows/amphora-image-build.yml, .github/workflows/ipa-image-build.yml, .github/workflows/overcloud-host-image-build.yml, .github/workflows/package-build-ofed.yml, .github/workflows/stackhpc-all-in-one.yml
The six jobs replace scalar environment names with mappings that set the same name and deployment: false.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Merge Risk: ⚪ Minimal · up to 8b894

The workflows retain their environments while suppressing deployment records. No concrete workflow failure is established, so no actionable merge blocker is identified.

Pre-merge checks: Passed 3
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (6 skipped: 6 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

When using environments in workflows they get treated as a deployment
which in unnecessary and leads to a trail of events associated with a
given `PR`.

See: https://docs.github.com/en/actions/how-tos/deploy/configure-and-manage-deployments/control-deployments#using-environments-without-deployments

Signed-off-by: Jack Hodgkiss <jack@stackhpc.com>
@priteau
priteau enabled auto-merge October 16, 2026 13:59

@Alex-Welsh Alex-Welsh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be very glad to never see that deployment spam again!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-review PR is waiting for a review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants