Revert run vars plugins

[Alex-Welsh]

ansible builtin modules have recently been failing with undefined errors.
Here's one for  ansible.builtin.file  https://github.com/stackhpc/stackhpc-kayobe-config/actions/runs/38570724510/job/115879649641?pr=2683#step:24:467
And here's one for ansible.builtin.setup https://github.com/stackhpc/stackhpc-kayobe-config/actions/runs/38543045422/job/115787007902?pr=2680#step:25:247

I think these are related to this run_vars_plugins option, which didn't trigger AIO CI when it was merged. See #2674

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: stackhpc/stackhpc-kayobe-config/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: 9aed8a9a-e6dc-4846-ad26-dcf3a952ef7e

📥 Commits

Reviewing files that changed from the base of the PR and between 5bfc457 and be2a3db.

📒 Files selected for processing: 2

• .github/stackhpc-pull-request-path-filters.yml
• etc/kayobe/ansible.cfg

💤 Files with no reviewable changes: 1

• etc/kayobe/ansible.cfg

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The change removes run_vars_plugins = start and its explanatory comment from the Ansible defaults. It also adds etc/kayobe/ansible.cfg to the paths matched by the aio filter.

Changes: Ansible configuration update

Layer / File(s)	Summary
Configuration change and path filtering .github/stackhpc-pull-request-path-filters.yml, etc/kayobe/ansible.cfg	The aio path filter now matches etc/kayobe/ansible.cfg. The [defaults] section no longer sets run_vars_plugins = start or includes its explanatory comment.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Merge Risk: ⚪ Minimal · up to be2a3

No concrete merge-blocking risk was identified in the configuration changes.

Pre-merge checks: 3

Passed checks: 3 passed

Check name	Status	Explanation
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[jovial]

It turns out that this stops kolla-ansible loading group_vars adjacent to the playbook (I think). This meant kolla playbooks were broken, by kayobe ones worked. Apologies, I thought the CI would check this!

[priteau]

Sorry, I didn't notice that it hadn't triggered AIO jobs.

[Alex-Welsh]

No worries all round, I also would've assumed this sort of change would trigger CI. Anyway, it will now 😉