VF-LAG host configure

[holliefae]

No description provided.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

• Configuration used: Repository: stackhpc/stackhpc-kayobe-config/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: 28c41d58-f9d6-4c0d-8c32-b87c0b4d7354

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

📝 Walkthrough

The pull request adds an Ansible playbook that prepares vflag hosts, configures SR-IOV, deploys VF-LAG scripts and systemd units, and applies OpenIB and Debian-specific system changes. It also adds a release note describing the script move to SKC.

Changes: VF-LAG host configuration

Layer / File(s)	Summary
SR-IOV and host preparation etc/kayobe/ansible/deployment/vf-lag-host-configure.yml	The playbook conditionally includes the SR-IOV role for vflag hosts. It prepares hosts by installing kernel-modules-extra on Red Hat or creating /etc/sysconfig on Debian. It templates the SR-IOV configuration and sets the reboot flag when that configuration changes.
VF-LAG service deployment etc/kayobe/ansible/deployment/vf-lag-host-configure.yml	The playbook deploys VF-LAG helper scripts and systemd units, reloads systemd, and enables both units. Changes to the scripts or units notify the reboot handler.
Host service integration etc/kayobe/ansible/deployment/vf-lag-host-configure.yml, releasenotes/notes/vflag-host-configure-4ba351fa23327e16.yaml	The playbook stops and disables openibd.service, conditionally moves openib.cf, and creates a Debian systemd .wants symlink. The release note describes the move from SMSLab Ansible to SKC.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: 🟡 Moderate · up to 5cac3

The new VF-LAG host configuration playbook fails lint validation. It can also fail on hosts that use a different SSH account or do not have the OFED openibd service installed. Fix these issues before merging.

Pre-merge checks: 3

Passed checks: 3 passed

Check name	Status	Explanation
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches: 💡 1

🛠️ Fix failing CI checks: 💡

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 4

---

ℹ️ Review info

⚙️ Run configuration

• Configuration used: Repository: stackhpc/stackhpc-kayobe-config/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: d2af00de-c84f-4d27-b472-f624c8a0afc4

📥 Commits

Reviewing files that changed from the base of the PR and between 11b667e and 5cac3fc.

📒 Files selected for processing: 2

• etc/kayobe/ansible/deployment/vf-lag-host-configure.yml
• releasenotes/notes/vflag-host-configure-4ba351fa23327e16.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

[coderabbitai]

🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

Check that openibd.service exists before disabling it.

If a VF-LAG host has no OFED service installed, this task fails rather than treating the service as already stopped. Ansible’s systemd module checks that the unit exists before it applies either enabled: false or state: stopped. The failure also prevents the later host tasks from completing. Check for the unit and run this task only when it exists. (raw.githubusercontent.com)

[holliefae]

I'm not sure whether this is important to catch, should we be running this script if OFED isn't installed?

[coderabbitai]

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
rg -n -i -C3 'ofed|openibd|vf-lag|vf_lag|vflag' --glob '!*.lock' --glob '!*.svg' . | head -n 280
fd -i 'mlnx-vflag|sysconfig-sriov'
ast-grep outline etc/kayobe/ansible/deployment/vf-lag-host-configure.yml

Length of output: 22668

---

@holliefae The documented workflow targets DOCA hosts. In doc/source/contributor/ofed.rst, the host configuration section places DOCA hosts in vflag and directs operators to run this playbook.

If OFED must already be installed, you do not need to support hosts without OFED. In that case, failing is reasonable. An explicit prerequisite check could give a clearer error, but it is not essential to this change.

The remaining question is whether every supported OFED/DOCA installation provides openibd.service. If that is guaranteed, my suggested guard is unnecessary. If a supported installation can omit the service, guard only this cleanup task.

My original Major rating was too strong without establishing that a supported host can lack the service.

You are interacting with an AI system.

[coderabbitai]

Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!

[Alex-Welsh]

explicit prerequisite check could give a clearer error

Let's go with this option @holliefae