Skip to content

Multinode cloud tests - #2669

Merged
Alex-Welsh merged 2 commits into
stackhpc/2026.1from
multinode-cloud-tests
Oct 16, 2026
Merged

Alex-Welsh merged 2 commits into
stackhpc/2026.1from
multinode-cloud-tests

Conversation

@RowanJohns

@RowanJohns RowanJohns commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Enable SCT on multinode workflow runs. Relies on these PRs:
Terraform kayobe multinode: stackhpc/terraform-kayobe-multinode#130
SCT: stackhpc/stackhpc-cloud-tests#20

Changes mostly involve improvements to the stackhpc-cloud-tests.yml playbook, as well as some minor changes to the ci-multinode environment for compatibility.

Jira ticket

@RowanJohns
RowanJohns requested a review from MoteHue October 12, 2026 13:42
@RowanJohns RowanJohns self-assigned this Oct 12, 2026
@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: stackhpc/stackhpc-kayobe-config/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9e164f66-fa1a-4274-840a-93a1b2b665bd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

The CI multinode environment configures sct_runner and an OpenStack CA certificate path. The cloud-test playbook runs monitoring and host tests on that group, sets test environment variables, and updates how it handles test results and failed-test reports.

Changes: CI Multinode Cloud Tests

Layer / File(s) Summary
Environment configuration
etc/kayobe/environments/ci-multinode/globals.yml, etc/kayobe/environments/ci-multinode/inventory/kayobe-automation, etc/kayobe/environments/ci-multinode/stackhpc-ci.yml, etc/kayobe/environments/ci-multinode/seed.yml
The environment configures the CA certificate path, adds the sct_runner inventory group, sets kayobe_environment to ci-multinode, and disables seed Pulp containers.
Runner selection and certificate setup
etc/kayobe/ansible/tools/stackhpc-cloud-tests.yml
The play targets sct_runner, checks that it has exactly one host, and creates and copies the configured CA certificate when defined.
Test execution and result handling
etc/kayobe/ansible/tools/stackhpc-cloud-tests.yml
Monitoring tests receive OpenSearch certificate settings. Host tests receive KAYOBE_ENVIRONMENT. Result permissions and synchronisation use privilege escalation. The failed-test report is copied only when its content is non-empty.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~12 minutes

Merge Risk: 🔵 Low · up to 7b792

The multinode cloud monitoring test may fail to trust the custom CA, or may run with verification disabled. This affects CI test reliability only, and should be fixed before relying on these runs.

Pre-merge checks | Passed 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the waiting-author-response PR is waiting for the author to respond label Oct 12, 2026
@RowanJohns
RowanJohns marked this pull request as ready for review October 12, 2026 13:45
@RowanJohns
RowanJohns requested a review from a team as a code owner October 12, 2026 13:45
@github-actions github-actions Bot added waiting-review PR is waiting for a review and removed waiting-author-response PR is waiting for the author to respond labels Oct 12, 2026
@RowanJohns
RowanJohns force-pushed the multinode-cloud-tests branch from 7f9457d to 7b792a6 Compare October 12, 2026 14:20
Comment thread etc/kayobe/environments/ci-multinode/inventory/kayobe-automation
Comment thread etc/kayobe/ansible/tools/stackhpc-cloud-tests.yml Outdated
Comment thread etc/kayobe/ansible/tools/stackhpc-cloud-tests.yml
Comment thread etc/kayobe/environments/ci-multinode/stackhpc-ci.yml Outdated
@github-actions github-actions Bot added waiting-author-response PR is waiting for the author to respond and removed waiting-review PR is waiting for a review labels Oct 12, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3


ℹ️ Review info
⚙️ Run configuration
  • Configuration used: Repository: stackhpc/stackhpc-kayobe-config/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4c4e54da-c403-409f-8db2-a1a50a9b148d
📥 Commits

Reviewing files that changed from the base of the PR and between fab7111 and 7b792a6.

📒 Files selected for processing (5)
  • etc/kayobe/ansible/tools/stackhpc-cloud-tests.yml
  • etc/kayobe/environments/ci-multinode/globals.yml
  • etc/kayobe/environments/ci-multinode/inventory/kayobe-automation
  • etc/kayobe/environments/ci-multinode/seed.yml
  • etc/kayobe/environments/ci-multinode/stackhpc-ci.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Comment thread etc/kayobe/ansible/tools/stackhpc-cloud-tests.yml Outdated
Comment thread etc/kayobe/ansible/tools/stackhpc-cloud-tests.yml Outdated
Comment thread etc/kayobe/ansible/tools/stackhpc-cloud-tests.yml
@RowanJohns
RowanJohns force-pushed the multinode-cloud-tests branch from 0ec1cc5 to 4e1dd3c Compare October 13, 2026 08:30
@RowanJohns
RowanJohns force-pushed the multinode-cloud-tests branch from b54a868 to 3c16774 Compare October 13, 2026 12:29
@RowanJohns RowanJohns added waiting-review PR is waiting for a review and removed waiting-author-response PR is waiting for the author to respond labels Oct 13, 2026
@RowanJohns
RowanJohns marked this pull request as ready for review October 13, 2026 14:34
@RowanJohns
RowanJohns marked this pull request as draft October 13, 2026 14:52

This branch was successfully deployed

1 active deployment
SMS Lab — 808e88bb Deployed Oct 16, 2026 by MoteHue via aio upgrade (Rocky 10 OVS) / All in one #8180
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-review PR is waiting for a review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants