Repository navigation
fix(mysql): apply keywordCase to INTERVAL duration expressions - #995
Closed
emirmrkaljevic wants to merge 1 commit into
Closed
emirmrkaljevic wants to merge 1 commit into
emirmrkaljevic wants to merge 1 commit into
Conversation
INTERVAL is listed as both a function and a keyword in MySQL-like
dialects. Without a following '(', it was demoted to IDENTIFIER, so
keywordCase left `interval 30 day` unchanged while MariaDB uppercased
it. Keep the non-call form as RESERVED_KEYWORD in the shared MariaDB
post-process path.
This was referenced Oct 19, 2026
Collaborator
|
I'm adopting a new policy for this repository: no AI-generated contributions. I don't care how good they are. This is to preserve my sanity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #985.
Problem
With
language: 'mysql'andkeywordCase: 'upper',intervalin duration expressions (interval 30 day) stayed lowercase. The same query undermariadbuppercased it toINTERVAL.MySQL lists
INTERVALas both a reserved keyword and a function name (INTERVAL(N, ...)). The tokenizer matches the function form first; when there is no following(,disambiguateTokensdemotes it toIDENTIFIER, sokeywordCasenever applies.Fix
In the shared MariaDB-like
postProcess, keepINTERVALasRESERVED_KEYWORDwhen it is not followed by(. Call formINTERVAL(...)stays a function name and still respectsfunctionCase.Tests
keywordCase: 'upper'INTERVAL(...)still formats as a functionFull suite: 5887 passed, 1 skipped.