Repository navigation
Make bean getter lookup independent of the default locale - #314
Open
curforever wants to merge 1 commit into
Open
curforever wants to merge 1 commit into
curforever wants to merge 1 commit into
Conversation
Fixes spullara#309. Generated-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #309.
Bean getter lookup currently uppercases the first property-name character using the default Locale. With Turkish or Azerbaijani defaults,
ingredientsbecomesİngredients, so lookup attemptsgetİngredients()instead of the existinggetIngredients()and renders a missing value.Use
Locale.ROOTfor this member-name conversion. Direct method/getter/field precedence, visibility checks, inheritance/interfaces, cache behavior and the existing full-string Unicode case mapping remain unchanged. No public API or dependency changes.Example with
getIngredients()returningcheeseandgetSauces()returningtomato, undertr_TR:{{ingredients}}/{{sauces}}/tomatocheese/tomatoValidation on Windows / Temurin8u504 / Maven3.9.11, with the existing Java8 POM:
mvn -B -ff -ntp clean package -pl '!benchmarks': 362 passing, 8 default skipped, zero failures/errors, all8 CI reactor projects.mvn -B -ff -ntp test -pl '!benchmarks': 362 passing, 8 default skipped, zero failures/errors. Repeated results are not counted as additional tests.Implementation and validation were assisted by OpenAI Codex. No human code-review approval is claimed.
The first full build stalled at the old HTTP Twitter repository. The exact required dependencies are available on official Maven Central, so the final runs use a B012-local settings mirror for repository id Twitter only. No POM, dependency version, global settings or TLS validation was changed; the interrupted attempt is preserved as incomplete.