Repository navigation
Conversation
…sponses Built-in filters and handlers (redirectTo, rateLimit, circuitBreaker, fn, stream) returned ServerResponse instances with read-only headers, so after filters such as addResponseHeader threw UnsupportedOperationException. Return GatewayServerResponse instead so response headers stay mutable. Fixes spring-cloudgh-4168 Signed-off-by: JoeCqupt <joe469391363@gmail.com>
Contributor
Author
|
@ryanjbaxter PTAL |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking into #4168, I found that several built-in filters and handlers in the WebMvc server return a plain
ServerResponse(e.g.ServerResponse.ok().build()). ServerResponse makes the headers read-only, so anyafterfilter that modifies response headers, such asaddResponseHeaderfails withUnsupportedOperationException.Built-in filters and handlers (redirectTo, rateLimit, circuitBreaker, fn, stream) returned ServerResponse instances with read-only headers, so after filters such as addResponseHeader threw UnsupportedOperationException. Return GatewayServerResponse instead so response headers stay mutable.