Repository navigation
Conversation
Disable the inherited automatic formatting execution and validate source formatting instead, so Maven builds expose violations in GitHub Actions rather than silently fixing them. Align RetryGatewayFilterFactory comments with the required formatting. Signed-off-by: JoeCqupt <joe469391363@gmail.com>
JoeCqupt
changed the title
spencergibb
requested changes
Oct 15, 2026
Keep the shared spring-cloud-build configuration unchanged while maintainers investigate the formatting validation behavior upstream. Signed-off-by: JoeCqupt <joe469391363@gmail.com>
JoeCqupt
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Running
mvn installlocally caused Spring Java Format to reformat comments inRetryGatewayFilterFactory, leaving unrelated changes in the working tree.The plugin configuration inherited from
spring-cloud-buildrunsapplybeforevalidate. As a result, formatting violations are silently corrected before validation, so CI can pass even when the committed source is not properly formatted.Changes
- Disable the inheritedapplyandvalidateexecution.- Bind a validation-only execution to the Mavenvalidatephase, preserving the existingdisable.checkssetting.- Align the existingRetryGatewayFilterFactorycomments with the required formatting.Both local and GitHub Actions builds will now report formatting violations instead of silently modifying source files. Developers can still runspring-javaformat:applyexplicitly to fix them.Apply Java formatting to
RetryGatewayFilterFactory.