Repository navigation
Fix: skip response header modifications when the response is committed - #4328
Merged
Merged
Conversation
Guard SetResponseHeader, RewriteResponseHeader, and DedupeResponseHeader against modifying committed responses and add regression tests. Fixes spring-cloudgh-3905 Signed-off-by: JoeCqupt <joe469391363@gmail.com>
Contributor
Author
|
@ryanjbaxter PTAL |
ryanjbaxter
reviewed
Oct 16, 2026
ryanjbaxter
left a comment
ryanjbaxter
left a comment
Contributor
There was a problem hiding this comment.
Can you check SecureHeadersGatewayFilterFactory and RewriteLocationResponseHeaderGatewayFilterFactory as well?
Guard SecureHeaders and RewriteLocationResponseHeader against modifying committed responses, and move the RewriteResponseHeader check into filter so subclasses overriding rewriteHeaders keep the guard. See spring-cloudgh-3905 Signed-off-by: joecqupt <joe469391363@gmail.com>
ryanjbaxter
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #3905