Skip to content

Fix bugs in Conductor deployment of java-slang - #111

Merged
martin-henz merged 20 commits into
mainfrom
conductor
Oct 27, 2026
Merged

martin-henz merged 20 commits into
mainfrom
conductor

Conversation

@kjw142857

Copy link
Copy Markdown
Contributor

This PR fixes the following issues/features:

  • Enables accepting of non-.class files when evaluating chunks, so that the Java evaluator can correctly evaluate chunks run in the Playground.
  • Enables inline autocomplete suggestions for common Java keywords.

@kjw142857
kjw142857 requested a review from martin-henz October 23, 2026 07:33
@kjw142857 kjw142857 self-assigned this Oct 23, 2026
@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Coverage report

St.❔
Category Percentage Covered / Total
🟡 Statements 71.51% 8447/11812
🔴 Branches 59.88% 2819/4708
🟡 Functions 69.97% 1505/2151
🟡 Lines 72.4% 7939/10965

Test suite run success

1251 tests passing in 75 suites.

Report generated by 🧪jest coverage report action from 6165099

@martin-henz

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T09:12:56.204221Z d0cbff1 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d0cbff1581

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/conductor/plugins/autocomplete/completions.ts Outdated
Comment thread src/conductor/JavaEvaluator.ts Outdated

@martin-henz martin-henz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martin-henz
martin-henz merged commit 60fcc2b into main Oct 27, 2026
5 checks passed
@martin-henz
martin-henz deleted the conductor branch October 27, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants