Skip to content

fix: update nonConformance value to non-conformance to match API - #109

Merged
solid-illiaaihistov merged 1 commit into
solid-software:mainfrom
solid-illiaaihistov:fix/non-conformance-mistake-type
Sep 24, 2026
Merged

solid-illiaaihistov merged 1 commit into
solid-software:mainfrom
solid-illiaaihistov:fix/non-conformance-mistake-type

Conversation

@solid-illiaaihistov

@solid-illiaaihistov solid-illiaaihistov commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the serialized value for the non-conformance mistake type to ensure consistent formatting.

@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: f6d26f77-6aa2-4346-990d-2db7e4fac28d

📥 Commits

Reviewing files that changed from the base of the PR and between edee4ec and df2014d.

📒 Files selected for processing (1)
  • lib/src/core/enums/mistake_type.dart

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The pull request changes the string value mapped to MistakeType.nonConformance from nonconformance to non-conformance.

Changes

Mistake type update

Layer / File(s) Summary
Update mistake type value
lib/src/core/enums/mistake_type.dart
MistakeType.nonConformance now maps to non-conformance.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to df201

The API value now uses the hyphenated spelling, matching the stated contract. No merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the change from "nonconformance" to "non-conformance" and states that the update matches the API.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@solid-illiaaihistov
solid-illiaaihistov merged commit f3347d7 into solid-software:main Sep 24, 2026
2 checks passed
@solid-illiaaihistov
solid-illiaaihistov deleted the fix/non-conformance-mistake-type branch September 24, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants