Repository navigation
docs: Fix js-legacy README build-from-source steps - #149
Open
imitater-dou wants to merge 1 commit into
Open
imitater-dou wants to merge 1 commit into
imitater-dou wants to merge 1 commit into
Conversation
The build-from-source section still cloned the archived solana-program-library repo and ran `npm run test:build-programs`, which does not exist in clients/js-legacy/package.json. Point it at this repo and clients/js-legacy, use pnpm like CI does, and run the unit tests instead. Also point the issue link at this repo. Signed-off-by: ADou <ikun3.1415927@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Build from Source" section of
clients/js-legacy/README.mdstill describes the oldsolana-program-librarylayout:solana-labs/solana-program-library(archived) andcds intotoken-metadata/js, which no longer exists there. The client lives inclients/js-legacyof this repo.npm run test:build-programs, butclients/js-legacy/package.jsonhas notest:build-programsscript. The tests (test/instruction.test.ts,test/state.test.ts) are plain mocha unit tests that don't need an on-chain program build.prepublishOnly: "pnpm build", rootpackageManager: pnpm@9.1.0, and CI'smake test-js-clients-js-legacyrunscd clients/js-legacy && pnpm install && pnpm build && pnpm test).Changes
cdsteps at this repo andclients/js-legacy.pnpm install/pnpm build, and replace the missingtest:build-programsstep withpnpm test(matching what CI runs).This matches the layout already used in
solana-program/memo'sclients/js-legacy/README.md. Docs only.How to verify