Skip to content

Feature/fix 515 and 325 - #516

Open
notactuallyfinn wants to merge 3 commits into
developfrom
feature/fix-515-and-325
Open

notactuallyfinn wants to merge 3 commits into
developfrom
feature/fix-515-and-325

Conversation

@notactuallyfinn

Copy link
Copy Markdown
Collaborator

Closes: #515
Closes: #325

Fixed error in init and clean commands caused by trying to remove audit.log using shutil.rmtree.
This was done by removing "auditfile" formatter and handler because they were unused.

@zyzzyxdonta zyzzyxdonta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't use Windows, so I never ran into this problem. I can neither confirm or deny that this works. If you tested it, this is fine.

Getting rid of the audit.log file makes sense to me. I don't know why we had multiple log files.

One thing: audit.log is still mentioned in docs/source/dev/data_model.md

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hermes init fails on Windows: WinError 32 on .hermes\audit.log (unwrapped rmtree + unclosed audit handler) hermes clean command fails

2 participants