Repository navigation
Salvage Value Rate rebase & minor version bump [v3.20] - #192
Merged
Merged
Conversation
…10% (NatLabRockies#516) Previously the salvage value was always 50% of total installed cost, from the SAM template inputs, and was not configurable. Salvage Value Rate sets SAM's salvage_percentage. The default of 10% matches SAM's own default. Regenerated SAM-EM example outputs.
…r 10% default salvage value (NatLabRockies#516)
…al instability incidentally introduced by new default Salvage Value Rate of 0.1
…5 default value to avoid changing nominally immutable previons version (legacy) results
1 of 4 tasks
softwareengineerprogrammer
changed the title
softwareengineerprogrammer
changed the title
softwareengineerprogrammer
marked this pull request as ready for review
October 17, 2026 18:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rebase and review comment resolution of NatLabRockies#536 to roll into NatLabRockies#535
Testing & Verification
Change Checklist
Observe the following checklist items before and after merging, as applicable.
Before merging:
After merging:
git push fork refs/tags/v3.20.1