Skip to content

fix: repo's typescript and ESlint configuration and errors #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hejsztynx wants to merge 11 commits into
base: main
Choose a base branch
from
Open

fix: repo's typescript and ESlint configuration and errors #796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d3243dd
fix: pin root typescript's react dependencies
hejsztynx Sep 10, 2026
89e32e1
chore: make example-web use the root typescript
hejsztynx Sep 10, 2026
9c4625e
fix: make example-web use the root's eslint
hejsztynx Sep 11, 2026
69ecadf
fix: add playwright tsconfig
hejsztynx Sep 11, 2026
53c6165
chore: lint
hejsztynx Sep 11, 2026
b28d943
fix: deprecated ref types in native spec files
hejsztynx Sep 11, 2026
ce26a78
fix: ternary operator logic
hejsztynx Sep 11, 2026
8a06b4e
refactor: add .playwright to ts exclude list
hejsztynx Sep 11, 2026
d66e98e
fix: remove unused example-web scripts
hejsztynx Sep 11, 2026
28227b7
fix: revert prettier version upgrade
hejsztynx Oct 12, 2026
4362ad2
Merge branch 'main' into @ksienkiewicz/fix-repo-ts-lint
hejsztynx Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .playwright/tests/codeblockInlineStyles.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const INLINE_MARK_TAG = /<\s*(b|i|u|s|code)\b/i;

function htmlInsideCodeblock(serialized: string): string {
const m = serialized.match(/<codeblock[^>]*>([\s\S]*?)<\/codeblock>/i);
return m ? m[1] : '';
return m && m[1] ? m[1] : '';
}

test.describe('codeblock inline styles', () => {
Expand Down
2 changes: 1 addition & 1 deletion .playwright/tests/headingBoldFromStyle.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { toolbarButton } from '../helpers/toolbar';

function h1Inner(serialized: string): string | null {
const m = serialized.match(/<h1[^>]*>([\s\S]*?)<\/h1>/);
return m ? m[1] : null;
return m?.[1] ?? null;
}

const HTML_STYLE_H1_BOLD_TRUE = '{ "h1": { "bold": true } }';
Expand Down
7 changes: 7 additions & 0 deletions .playwright/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"extends": "../tsconfig.base.json",
"compilerOptions": {
"types": ["node"],
},
"include": ["**/*.ts"],
}
32 changes: 0 additions & 32 deletions apps/example-web/eslint.config.mjs
View file
Open in desktop

This file was deleted.

21 changes: 6 additions & 15 deletions apps/example-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,28 +5,19 @@
"type": "module",
"scripts": {
"dev": "vite",
"build:web": "tsc -b && vite build",
"preview": "vite preview",
"lint": "eslint . --ext ts,tsx"
"build:web": "vite build",
Comment thread
hejsztynx marked this conversation as resolved.

@hejsztynx hejsztynx Sep 11, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we can safely remove that tsc call. It was there, because we had a standalone TS, but now we use the root one and we use the root yarn typecheck

"preview": "vite preview"
},
"dependencies": {
"react": "^19.1.0",
"react-dom": "^19.1.0"
"react": "19.2.3",
"react-dom": "19.2.3"
},
"devDependencies": {
"@eslint/js": "^9.39.1",
"@types/node": "^24.10.1",
"@types/react": "^19.1.0",
"@types/react-dom": "^19.2.3",
"@types/react": "^19.2.0",
"@types/react-dom": "^19.2.0",
"@vitejs/plugin-react": "^5.1.1",
"eslint": "^9.22.0",
"eslint-plugin-react-dom": "^2.3.13",
"eslint-plugin-react-hooks": "^7.0.1",
"eslint-plugin-react-refresh": "^0.4.24",
"eslint-plugin-react-x": "^2.3.13",
"globals": "^16.5.0",
"typescript": "^5.8.3",
"typescript-eslint": "^8.46.4",
"vite": "^7.2.4"
Comment thread
hejsztynx marked this conversation as resolved.
},
"engines": {
Expand Down
10 changes: 7 additions & 3 deletions apps/example-web/tsconfig.app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,12 @@
"tsBuildInfoFile": "./node_modules/.tmp/tsconfig.app.tsbuildinfo",
"types": ["vite/client"],
"paths": {
"react-native-enriched-html": ["../../src/index.tsx"]
}
"react-native-enriched-html": ["../../src/index.tsx"],
"react": ["../../node_modules/@types/react"],
"react/*": ["../../node_modules/@types/react/*"],
"react-dom": ["../../node_modules/@types/react-dom"],
"react-dom/*": ["../../node_modules/@types/react-dom/*"],
Comment on lines +8 to +11

@exploIF exploIF Oct 8, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this mapping is needed? Looks like a workaround for incorrect versions. This should be fixed differently, as those mappings were not needed before

@hejsztynx hejsztynx Oct 12, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These mappings aren't needed, but I wanted to make that file consistent with apps/example/tsconfig, where those mapping were present. But I'm open to reverting that change

},
},
"include": ["src"]
"include": ["src"],
}
4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,12 @@
"docs-install": "cd docs && yarn install",
"docs-start": "cd docs && yarn start",
"test": "jest --passWithNoTests",
"typecheck": "yarn typecheck:lib && yarn typecheck:example && yarn typecheck:example-web",
"typecheck": "yarn typecheck:lib && yarn typecheck:example && yarn typecheck:example-web && yarn typecheck:playwright",
Comment thread
hejsztynx marked this conversation as resolved.
"typecheck:lib": "tsc -p tsconfig.build.json",
"typecheck:example": "tsc -p apps/example/tsconfig.json",
"typecheck:example-web": "tsc -p apps/example-web/tsconfig.app.json",
"typecheck:docs": "cd docs && yarn typecheck",
"typecheck:playwright": "tsc -p .playwright/tsconfig.json",
"lint": "eslint \"**/*.{js,ts,tsx}\"",
"lint:android": "cd apps/example/android && ./gradlew lintVerify",
"lint:android:fix": "cd apps/example/android && ./gradlew lintFormat",
Expand Down Expand Up @@ -125,6 +126,7 @@
"@react-native/jest-preset": "^0.87.0",
"@release-it/conventional-changelog": "^9.0.2",
"@types/jest": "^29.5.5",
"@types/node": "^22.20.2",
"@types/react": "^19.2.0",
"@types/react-dom": "^19.2.0",
"clang-format": "^1.8.0",
Expand Down
55 changes: 27 additions & 28 deletions src/spec/EnrichedTextInputNativeComponent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import type {
HostComponent,
ViewProps,
} from 'react-native';
import React from 'react';

export interface LinkNativeRegex {
pattern: string;
Expand Down Expand Up @@ -417,69 +416,69 @@ type ComponentType = HostComponent<NativeProps>;

interface NativeCommands {
// General commands
focus: (viewRef: React.ElementRef<ComponentType>) => void;
blur: (viewRef: React.ElementRef<ComponentType>) => void;
setValue: (viewRef: React.ElementRef<ComponentType>, text: string) => void;
focus: (viewRef: React.ComponentRef<ComponentType>) => void;
blur: (viewRef: React.ComponentRef<ComponentType>) => void;
setValue: (viewRef: React.ComponentRef<ComponentType>, text: string) => void;
setSelection: (
viewRef: React.ElementRef<ComponentType>,
viewRef: React.ComponentRef<ComponentType>,
start: CodegenTypes.Int32,
end: CodegenTypes.Int32
) => void;

// Text formatting commands
toggleBold: (viewRef: React.ElementRef<ComponentType>) => void;
toggleItalic: (viewRef: React.ElementRef<ComponentType>) => void;
toggleUnderline: (viewRef: React.ElementRef<ComponentType>) => void;
toggleStrikeThrough: (viewRef: React.ElementRef<ComponentType>) => void;
toggleInlineCode: (viewRef: React.ElementRef<ComponentType>) => void;
toggleH1: (viewRef: React.ElementRef<ComponentType>) => void;
toggleH2: (viewRef: React.ElementRef<ComponentType>) => void;
toggleH3: (viewRef: React.ElementRef<ComponentType>) => void;
toggleH4: (viewRef: React.ElementRef<ComponentType>) => void;
toggleH5: (viewRef: React.ElementRef<ComponentType>) => void;
toggleH6: (viewRef: React.ElementRef<ComponentType>) => void;
toggleCodeBlock: (viewRef: React.ElementRef<ComponentType>) => void;
toggleBlockQuote: (viewRef: React.ElementRef<ComponentType>) => void;
toggleOrderedList: (viewRef: React.ElementRef<ComponentType>) => void;
toggleUnorderedList: (viewRef: React.ElementRef<ComponentType>) => void;
toggleBold: (viewRef: React.ComponentRef<ComponentType>) => void;
toggleItalic: (viewRef: React.ComponentRef<ComponentType>) => void;
toggleUnderline: (viewRef: React.ComponentRef<ComponentType>) => void;
toggleStrikeThrough: (viewRef: React.ComponentRef<ComponentType>) => void;
toggleInlineCode: (viewRef: React.ComponentRef<ComponentType>) => void;
toggleH1: (viewRef: React.ComponentRef<ComponentType>) => void;
toggleH2: (viewRef: React.ComponentRef<ComponentType>) => void;
toggleH3: (viewRef: React.ComponentRef<ComponentType>) => void;
toggleH4: (viewRef: React.ComponentRef<ComponentType>) => void;
toggleH5: (viewRef: React.ComponentRef<ComponentType>) => void;
toggleH6: (viewRef: React.ComponentRef<ComponentType>) => void;
toggleCodeBlock: (viewRef: React.ComponentRef<ComponentType>) => void;
toggleBlockQuote: (viewRef: React.ComponentRef<ComponentType>) => void;
toggleOrderedList: (viewRef: React.ComponentRef<ComponentType>) => void;
toggleUnorderedList: (viewRef: React.ComponentRef<ComponentType>) => void;
toggleCheckboxList: (
viewRef: React.ElementRef<ComponentType>,
viewRef: React.ComponentRef<ComponentType>,
checked: boolean
) => void;
addLink: (
viewRef: React.ElementRef<ComponentType>,
viewRef: React.ComponentRef<ComponentType>,
start: CodegenTypes.Int32,
end: CodegenTypes.Int32,
text: string,
url: string
) => void;
removeLink: (
viewRef: React.ElementRef<ComponentType>,
viewRef: React.ComponentRef<ComponentType>,
start: CodegenTypes.Int32,
end: CodegenTypes.Int32
) => void;
addImage: (
viewRef: React.ElementRef<ComponentType>,
viewRef: React.ComponentRef<ComponentType>,
uri: string,
width: CodegenTypes.Float,
height: CodegenTypes.Float
) => void;
startMention: (
viewRef: React.ElementRef<ComponentType>,
viewRef: React.ComponentRef<ComponentType>,
indicator: string
) => void;
addMention: (
viewRef: React.ElementRef<ComponentType>,
viewRef: React.ComponentRef<ComponentType>,
indicator: string,
text: string,
payload: string
) => void;
requestHTML: (
viewRef: React.ElementRef<ComponentType>,
viewRef: React.ComponentRef<ComponentType>,
requestId: CodegenTypes.Int32
) => void;
setTextAlignment: (
viewRef: React.ElementRef<ComponentType>,
viewRef: React.ComponentRef<ComponentType>,
alignment: string
) => void;
}
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"extends": "./tsconfig",
"exclude": ["apps", "lib", "cpp/build", "docs"]
"exclude": ["apps", "lib", "cpp/build", "docs", ".playwright"],
}
9 changes: 6 additions & 3 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
{
"extends": "./tsconfig.base.json",
"exclude": ["docs"],
"compilerOptions": {
"rootDir": ".",
"types": ["jest"],
"paths": {
"react-native-enriched-html": ["./src/index.native"]
}
}
"react-native-enriched-html": ["./src/index.native"],
"react": ["./node_modules/@types/react"],
"react/*": ["./node_modules/@types/react/*"],
},
},
}
Loading
Loading