Repository navigation
HTTP Client cURL issues - #146
Merged
Merged
Conversation
Make GitHub Action test workflow pass
Call curl_close() only when the handle is a resource (PHP < 8.0); since PHP 8.0 it is a CurlHandle object freed automatically, and curl_close() is deprecated in PHP 8.5.
Wrap execute() in try/finally so closeHttpClient() also runs when RequestException is thrown, preventing the handle from being left open on PHP < 8.0.
maciejlew
force-pushed
the
http-client-curl-issues
branch
from
October 20, 2026 12:22
59e428d to
281f354
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #145:
curl_close()is now called based on the handle type (is_resource()) instead of the PHP version, andexecute()is wrapped intry/finallyso the cURL handle is also closed when the request fails on PHP-7. Adds a 4.0.1 CHANGELOG entry covering these fixes and the ones from #145.