Repository navigation
chore: support Ruby 3.1 across Smithy gems (part 3) - #381
Merged
Merged
Conversation
jterapin
added this pull request to stack #382
October 14, 2026 23:25
jterapin
marked this pull request as ready for review
October 15, 2026 21:37
richardwang1124
approved these changes
Oct 16, 2026
jterapin
force-pushed
the
ruby-3.1-minimum-part-3
branch
2 times, most recently
from
October 21, 2026 14:56
3854f58 to
ec5b50d
Compare
peterrsongg
approved these changes
Oct 21, 2026
jterapin
force-pushed
the
ruby-3.1-minimum-part-3
branch
from
October 21, 2026 16:41
ec5b50d to
d7b0385
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Stacked on #380, which includes the runtime preparation from #378. Retarget to
mainafter both parents merge. Local validation is complete; GitHub CI is pending.Context
The gems currently require Ruby 3.3. This lowers the minimum requirement to Ruby 3.1 for the generator, runtimes, server placeholder, and generated client/schema gems.
Description
...forwarding inPageEnumerator#reduce.TempfilebeforeFilein log formatting so JRuby 9.4 retains the temporary-file label. Existing logging examples cover both paths..bundle/so local Bundler settings stay out of commits.Testing
Generator and runtime suites passed in the source checkout on Ruby 3.1.7, 3.2.11, 3.3.11, 3.4.9, 4.0.3, JRuby 9.4.15.0, and JRuby 10.0.7.0. All suites had zero failures; existing pending tests are included below.
.bundle/configis ignored andgit diff --checkpasses.LoadErrorbecause its existing source-relative CBOR protocol path requires the repository layout; the packaging fix is deferred with a TODO.git diff --checkpassed.reducecalling forms passed on Ruby 3.1.7, JRuby 9.4.15.0, and JRuby 10.0.7.0.🤖 This PR description was drafted with AI assistance for @jterapin. ✨