Skip to content

feat(smithy-json): add eager deserialization #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stobrien89 wants to merge 3 commits into
base: develop
Choose a base branch
from
+173 −192
Open

feat(smithy-json): add eager deserialization #850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8261249
feat(smithy-json): add configurable eager deserialization
stobrien89 Oct 10, 2026
d510b7e
remove modes - always eager
stobrien89 Oct 13, 2026
9ba0f39
rename new parser
stobrien89 Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...ithy-json/.changes/next-release/smithy-json-feature-4b7f9ca09557405eb9382c56490c6d7a.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"type": "feature",
"description": "JSON payloads are now eagerly parsed before deserialization, improving performance for both `bytes` and `BytesReader` inputs."
}
6 changes: 6 additions & 0 deletions packages/smithy-json/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,9 @@

This package provides generic JSON serialization and deserialization support
for Smithy clients and servers.

## Deserialization

`JSONCodec` eagerly parses `bytes` and `BytesReader` payloads before
deserializing Smithy shapes. This improves deserialization performance while
temporarily materializing the complete JSON value tree.
4 changes: 0 additions & 4 deletions packages/smithy-json/src/smithy_json/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
# SPDX-License-Identifier: Apache-2.0
from io import BytesIO

from smithy_core.codecs import Codec
from smithy_core.deserializers import ShapeDeserializer
from smithy_core.interfaces import BytesReader, BytesWriter
Expand Down Expand Up @@ -56,6 +54,4 @@ def create_serializer(self, sink: BytesWriter) -> "ShapeSerializer":
return _JSONShapeSerializer(sink, settings=self._settings)

def create_deserializer(self, source: bytes | BytesReader) -> "ShapeDeserializer":
if isinstance(source, bytes):
source = BytesIO(source)
return _JSONShapeDeserializer(source, settings=self._settings)
Loading
Loading