Repository navigation
Add output buffer pooling - #1410
Merged
Merged
Conversation
mtdowling
approved these changes
Oct 12, 2026
adwsingh
force-pushed
the
adwsingh/buffer-pooling-lifecycle
branch
from
October 12, 2026 22:03
3ae8adc to
641f796
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What behavior changes?
Client serializers reuse output arrays, and the pipeline releases pooled request bodies after all retry attempts complete. Reads from a released pooled body throw an exception.
Why is this change needed?
This reduces allocations and copies during serialization while defining when transports and interceptors can safely retain request bodies.
How was this validated?
New tests cover buffer reuse, aliases, retries, timeouts, wrappers, and failed serialization. At the time of this update, Java 25 CI for Linux and macOS is still running.
What should reviewers focus on?
Check
OutputBuffers.java,LeasedDataStream.java, andClientPipeline.javafor pool limits, alias copies, and release timing. Check transport timeout handling and wrappers for safe body reuse.Additional Links
This PR has no additional links.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.