Repository navigation
Conversation
Legacy telemetry is loss-tolerant, and OTI's own traffic through chip-ingress is already produced with acks=0. Send it with the batch client's WithNoAck option so chip-ingress answers once it has validated the events and handed them to its Kafka producer, instead of waiting for the broker. - Add batch.WithNoAck() and set batch.WithTransactionEnabled(false) explicitly, so per-event results no longer depend on the library default. - Bump pkg/chipingress to chainlink-common#2491 in every module. This pins an unmerged commit and must be re-pinned to main before ready. - Say in the docs and comments that "sent" now means accepted by chip-ingress's producer, not persisted. - Tests: the mock chip client serves PublishBatchNoAck only and fails on PublishBatch; add coverage for transaction_enabled=false and for a partially rejected batch counting per event. The test client uses the shipped batch and drain defaults. A chip-ingress without PublishBatchNoAck fails every batch with Unimplemented and there is no fallback, so the server must deploy first.
Contributor
|
✅ No conflicts with other open PRs targeting |
Contributor
|
I see you updated files related to
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INFOPLAT-19548
Stacked on #23949 (base is that PR's branch; review only this PR's commit). Retarget to
developonce #23949 merges.What
batch.WithNoAck(), so batches go out asPublishBatchNoAck(server-side Kafkaacks=0) instead ofPublishBatch.batch.WithTransactionEnabled(false)explicitly (partial delivery, per-event results) instead of relying on the library default.pkg/chipingressin all 9 modules to the head of chipingress/batch: add WithNoAck option chainlink-common#2491.acks=0.ChipIngressEnableddocs and code comments now say what "sent" means.Why
Follow-up to the round-3 review of #23949 (comment). With NoAck the server answers once it has validated the events and handed them to its producer, so a slow broker no longer holds the batch client's send slots. That shortens in-flight time, which helps the shutdown drain, the batch-split cost and reordering across concurrent sends.
telemetry_client_messages_sentkeeps its name and its WSRPC meaning. For the chip path it now means "validated and handed to the producer, not persisted".Tests
go test -race ./core/services/synchronization/... ./core/services/telemetry/... ./core/config/...plus the config, resolver andTestScriptssuites.PublishBatchNoAck. An ackedPublishBatchcall fails the test.transaction_enabled=false; a mixed per-event result countssent = n-1andsend_errors = 1.WithNoAck(), or settingWithTransactionEnabled(true), fails the new tests.MaxBatchSize100,DrainTimeout1s).Not tested: NoAck against a real chip-ingress. That needs atlas#13777.
Before this leaves draft
pkg/chipingressre-pinned from the EthTxManager has more resilient retry behavior and nonce tracking (WIP) #2491 head to the mergedmaincommit (the pin currently points at an unmerged branch).developafter [INFOPLAT-19425] Send legacy telemetry via a dedicated chip-ingress batch client #23949 merges.ChipIngressEnabledanywhere until atlas#13777 is deployed on the legacy deployment. There is no fallback toPublishBatch: an older server returnsUnimplementedfor every batch while the health Ping stays green (the M6 breaker should treat that as permanent).Internalfor the whole request, which undoes BCI-3619 Fix TestHeadTracker_CallsHeadTrackableCallbacks flaky test #13712's per-event produce failures for this traffic.