[agparadiso]

Description

This pr closes the following metrics/logs gaps between legacy and coordinated engines.

Drop metrics are missing and logs are too noisy

Difference

• Legacy: each drop increments TriggerEventDroppedTotal{reason} and calls the OnTriggerEventDropped hook (engine.go:291-298, engine.go:372-377). Expected errors are logged at Info (engine.go:405-409).
• Coordinated:
  • If the engine is draining, ExecuteTrigger returns ErrEngineDraining (base_engine.go:219). The coordinator only writes a log line. There is no metric and no hook call.
  • "Engine gone" and "engine not coordinated" drops (coordinator.go:324-331) have no metric.
  • The coordinator logs ErrDuplicateExecution, ErrEngineDraining, and ErrEngineClosed at Error (coordinator.go:335).

Risk

• On staging, we cannot see the dropped events.
• Error logs for normal events can trigger alerts.

Metric labels are different

Difference

• Legacy engine metrics have these labels: workflowID, owner, name, sdk, orgID (base_engine.go:165-171, base_engine.go:416).
• Coordinator metrics have no sdk label (coordinator.go:173-178). This applies to ACK success/failure, trigger received, trigger response error, register failure, and registered/unregistered counters.
• The coordinator increments IncrementWorkflowUnregisteredCounter only when unregistration succeeds. The legacy engine increments it on each close (engine.go:198).

Risk

• Dashboards that group by sdk show wrong totals for coordinated workflows.

CRE-6178

Requires

Supports

Deployment Validation Steps

only metrics changes, canaries 🟢 should be enough

[github-actions]

👋 agparadiso, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

[github-actions]

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

• #added For any new functionality added.
• #breaking_change For any functionality that requires manual action for the node to boot.
• #bugfix For bug fixes.
• #changed For any change to the existing functionality.
• #db_update For any feature that introduces updates to database schema.
• #deprecation_notice For any upcoming deprecation functionality.
• #internal For changesets that need to be excluded from the final changelog.
• #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
• #removed For any functionality/config that is removed.
• #updated For any functionality that is updated.
• #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

[github-actions]

✅ No conflicts with other open PRs targeting develop

[cl-sonarqube-production]

Quality Gate passed

Issues
0 New issues
11 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[trunk-io]

   

View Full Report ↗︎ ⋅ Docs