[MStreet3]

WorkflowIDFromHex accepted uppercase and mixed-case hex, because hex.DecodeString does, so several spellings of one ID parsed to the same WorkflowID.

Fix

This PR removes the possibility of decoding any non-canonical workflow IDs (i.e., 64 lowercase hex
characters with no 0x prefix).

Problem

• The trigger coordinator keys its registry and trigger registration IDs on the workflow ID string it was given, but releases a trigger registration by encoded hex (e.g., WorkflowID.Hex()). The workflow syncer also unregisters by Hex().
• A non-canonical ID would miss those lookups, leaving the triggers registered and the workflow's limit slot in use.

Requires

Supports

• resolves 6 from this comment

Deployment Validation Steps

[github-actions]

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

• #added For any new functionality added.
• #breaking_change For any functionality that requires manual action for the node to boot.
• #bugfix For bug fixes.
• #changed For any change to the existing functionality.
• #db_update For any feature that introduces updates to database schema.
• #deprecation_notice For any upcoming deprecation functionality.
• #internal For changesets that need to be excluded from the final changelog.
• #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
• #removed For any functionality/config that is removed.
• #updated For any functionality that is updated.
• #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

[github-actions]

✅ No conflicts with other open PRs targeting develop

[cl-sonarqube-production]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[trunk-io]

   

View Full Report ↗︎ ⋅ Docs