Skip to content

cre-7120: decode core defaults per call to avoid shared mutable state - #24052

Open
mchain0 wants to merge 1 commit into
developfrom
cre-7120
Open

cre-7120: decode core defaults per call to avoid shared mutable state#24052
mchain0 wants to merge 1 commit into
developfrom
cre-7120

Conversation

@mchain0

@mchain0 mchain0 commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

cre-7120

Fixes failures like this one

@github-actions

github-actions Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions

github-actions Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@cl-sonarqube-production

cl-sonarqube-production Bot commented Oct 22, 2026

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
1 Fixed issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@trunk-io

trunk-io Bot commented Oct 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

@mchain0
mchain0 marked this pull request as ready for review October 22, 2026 11:53
@mchain0
mchain0 requested review from a team as code owners October 22, 2026 11:53
@mchain0
mchain0 requested a review from jmank88 October 22, 2026 11:53
Tofel
Tofel approved these changes Oct 22, 2026
View reviewed changes

@Tofel Tofel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope the that overhead of parsing TOML isn't noticeable

jmank88
jmank88 reviewed Oct 22, 2026
View reviewed changes
Comment thread core/config/docs/defaults.go
}

func CoreDefaults() (c toml.Core) {
c.SetFrom(&defaults)

@jmank88 jmank88 Oct 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix this in SetFrom? That is already meant to be doing a deep clone.

@jmank88 jmank88 Oct 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we just got sloppy with setting pointers instead of copying values? I think we want to fix that regardless

@jmank88 jmank88 Oct 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that it often hasn't mattered in the past since we would just point to a new place rather than update the value anyways.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmank88 jmank88 jmank88 left review comments
@Tofel Tofel Tofel approved these changes
@cedric-cordenier cedric-cordenier Awaiting requested review from cedric-cordenier
@kalverra kalverra Awaiting requested review from kalverra

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mchain0 @jmank88 @Tofel