Repository navigation
Conversation
ConvertDataSliceFromProto mapped 0 to nil through ptrUint64. A dataSlice
starting at offset 0 was then sent to the RPC node as offset: null, which
getAccountInfo rejects ("invalid type: null, expected usize"), so any
read of the first bytes of an account failed. Offset and length are both
required when a dataSlice is set, so pass them through unchanged.
Contributor
📊 API Diff Results
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConvertDataSliceFromProtoconvertedOffsetandLengthwithptrUint64, which returns nil for 0. ADataSlice{Offset: 0, Length: N}therefore reached solana-go with a nil offset and was sent to the RPC node as"offset": null, whichgetAccountInforejects:Any
GetAccountInfoWithOptscall that slices from the start of an account fails this way, through the relayer and the CRE Solana write/read capability. Found while reading Data Feeds accounts from a CRE workflow on Solana devnet; the workaround so far was to start every slice at offset 1.Offset and length are both required by the RPC when a data slice is set, and 0 is a valid offset, so they are now passed through unchanged. The other
ptrUint64call sites are optional fields and are not touched.Test:
TestConvertDataSliceFromProto_ZeroOffsetfails on main (nil offset) and passes with the change.