Repository navigation
Fix what the review of the held-branch work found - #8
Merged
Merged
Conversation
A /code-review of #7 found 15 issues, items 19 to 33 in docs/test-coverage-gaps.md. Each fix has a test that fails without it. - r refuses an upstream that is not a branch, such as a pull request head. It pushed the delete of a teammate's branch with the tracking name. - pruner.protect globs match both the name a row shows and the name on the remote. Each remote's trunk, from <remote>/HEAD, is protected. - The confirm screen names the remote branch a renamed row deletes. A refusal from r no longer stays on screen. - The held-branch check lists linked worktrees instead of globbing the repo path, trusts BISECT_START only while BISECT_LOG exists, and no longer needs git 2.31. - c makes x from team/a/x when a remote name holds a slash. - In a partial clone, git switch runs with no terminal, and commit counts keep the local cap of 8. - Commit counts run off the update loop: every reload's merge queries, and the count d starts. A slow partial clone no longer freezes the screen. - A failed count is a riskFailed flag, not -1 in the count field. One new item, 34, is open: the force retry still runs deletes and pushes inside Update. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
/code-reviewof #7 found 15 issues (items 19 to 33 indocs/test-coverage-gaps.md). Each fix has a test that fails with the fix taken out. The git facts behind 19, 23 and 24 were reproduced in throwaway repos first.rand pull requests:rnow refuses an upstream that is not a branch, such asrefs/pull/1/head. Before, it pushed the delete of a teammate's branch with the tracking name.pruner.protectglobs match both the name a row shows and the name on the remote. Each remote's trunk, from<remote>/HEAD, is protected, not only the default remote's.rno longer stays on screen.[,*or?in the repo path no longer hides them.BISECT_STARTcounts only whileBISECT_LOGexists, as in git. The check no longer needs git 2.31.con a remote row: a remote namedteam/agivesxfromteam/a/x, nota/x.git switchruns with no terminal, so ssh cannot prompt over the screen. Commit counts keep the local cap of 8, not the push cap of 3.dstarts.dopens the confirmation screen when they land.riskFailedflag, not-1in the count field. Every "commits at risk" check usesatRisk().One new item, 34, is open: the force retry still runs deletes and pushes inside
Update.Tests: 3 new, and new cases in existing tests. 108 in total, passing under
-race.🤖 Generated with Claude Code