Repository navigation
Show diff load progress and stop delta on leave - #10
Merged
Merged
Conversation
A large diff spent about 2s in delta behind a still "loading diff…" line, which looked like a frozen screen. The read and the layout are now two steps, so the loading line shows a spinner, the step, the line count, and the time so far. Leaving the diff, or starting another layout, now kills the running delta. Before, its answer was dropped but it ran to the end on one CPU core. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
von a large diff showed a still "loading diff…" line for about 2s while delta ran. It looked frozen.⠹ delta is styling 121,800 lines… 1.4s.Test plan
TestLeavingDiffStopsDelta(fails without the fix),TestDiffSpinnerTicksWhileLoading,TestGroupDigits.go test -racepasses.q.🤖 Generated with Claude Code