Repository navigation
Add counts to every binding and async readers to Python - #34
Merged
Merged
Conversation
- text::count and csv::count in Rust; count_text, count_csv, count_tsv and count_psv in Python; each equals the rows the matching reader yields, and all three conformance runners now check that on every case. - TextSpliterator.count decodes a row whose blank test hits non-ASCII bytes, so a row of Unicode spaces is no longer counted but not yielded. - aread_text, aread_jsonl, aread_csv, aread_tsv and aread_psv read each batch on a worker thread. - The Python options live in one TypedDict and defaults table per format, shared by the sync, async and count functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Counts in Rust (
text::count,csv::count) and Python (count_text,count_csv,count_tsv,count_psv), async Python readers (aread_*), and a fix toTextSpliterator.count, which counted rows of Unicode spaces thatfromdrops. All three conformance runners now assert that every count equals the rows the reader yields.