improvement(desktop): Electron E2E for desktop tool lifetimes against a live local Sim

[waleedlatif1]

Summary

• New Electron E2E spec runs the real desktop app against a live local Sim (Postgres, Redis, realtime). A recording proxy sits at the app origin and a scripted stand-in worker sits at SIM_AGENT_API_URL.
• Covers the ungated desktop fixes:
  • a browser call issued after switching chats fails as not started after the 15 s pickup grace (fix(mothership): fail unclaimed desktop calls fast and stop dropping them silently #8652)
  • leaving the chat doesn't end a running read_local_file, and an import survives chat switches (fix(mothership): keep local file tools running when the chat view changes #8666)
  • Stop from the reopened chat cancels the running import (fix(mothership): keep local file tools running when the chat view changes #8666)
  • signing out cancels a running desktop tool at sign-out (fix(mothership): end desktop tools at sign-out and settle held reports as final #8673)
  • unapproved reads and terminal runs, and a claim that arrives after Stop, are refused (fix(mothership): refuse desktop claims for unapproved or stopped calls #8643)
• Flag-off dormancy (feat(desktop): device registry, inbox and leased claims for a background executor #8644/feat(desktop): bind turns to a desktop and enforce its deadlines from the row #8650/fix(desktop): inbox persistence order, desktop-only overdue sweep, and ungated pickup windows #8685): a foreground round trip with a desktop tool works, the server doesn't bind a desktop that offers itself, no desktop_devices row is written, no executor routes are hit, and no inbox doorbell is published.
• Assertions are on observable outcomes: the result the model is resumed with, the workspace files, the persisted call rows, and the requests that reach Sim.
• The spec skips unless a live Sim is configured. A new desktop-live-e2e CI job starts one (dev app, realtime, Postgres, Redis), warms the routes the tests use, and runs the spec under Xvfb.

Type of Change

• Tests

Testing

• 8/8 green on staging 482f146d, on Linux/Xvfb and on macOS
• The CI step was run from scratch on a Linux runner
• Each test fails when its fix is reverted

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Oct 7, 2026 2:14am UTC

[cubic-dev-ai]

All reported issues were addressed across 5 files

<sub>Reply with feedback, questions, or to request a fix.

Fix all with cubic | Turn on auto-fix | Re-trigger cubic</sub>

[greptile-apps]

Confidence Score: 5/5

[Medium risk] Adds end-to-end tests for desktop tools against a local app.

The PR appears safe to merge; the latest helper replacement preserves the test's behavior.

What we checked:

• Desktop capabilities stay intact: The app sends capabilities as a plain object. toRecord() returns that object unchanged, so the rewritten request keeps its fields.

Summary

Adds eight Electron E2E tests against a live local Sim, plus a dedicated CI job.

• Checks tool behavior across chat switches, Stop, sign-out, and approval.
• Checks that foreground tools work without starting the background executor.
• The latest change replaces an inline object check with toRecord(). No new actionable issue was found.
• Previous threads are all unnumbered and resolved. The shared-helper fixes and Redis acknowledgment fix remain present. The Electron launch finding was correctly disputed by waleedlatif1 and conceded by Greptile.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Electron[Electron app] --> Proxy[Recording proxy]
  Proxy --> Sim[Local Sim]
  Sim --> Agent[Scripted worker]
  Sim --> Postgres[PostgreSQL]
  Sim --> Redis[Redis]
  Tests[E2E tests] --> Electron
  Tests --> Proxy
  Tests --> Postgres
  Tests --> Monitor[Redis monitor]
  Redis --> Monitor

Loading

_{Reviews (3) · Last reviewed commit: "improvement(desktop): read the chat body..." · Reviewed by Greptile}

[waleedlatif1]

@greptileai review

[waleedlatif1]

@greptileai review