You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Persist the accepted Trigger run ID before a keyed enqueue returns, so immediate workflow polling can resolve the run before Trigger's tag index catches up. Reuse the existing idempotency result table and retain tag lookup for older jobs.
Cancel the known root run after verifying its workflow, execution, task type, and active status. Treat receipt-write failures as ambiguous acceptance so callers retain their claim and retry safely.
Type of Change
Bug fix
Testing
142 focused queue, cancellation, and execution tests passed; 116 queue/cancellation tests rerun after rebasing onto latest staging.
Five real-PostgreSQL regressions passed with bun run test:integration trigger-dev.integration.ts; report: apps/sim/test-results/integration.json. The original code failed immediate lookup and cancellation. Removing each binding, scope, active-status, and deduplication guard also failed its regression.
App type-check, repository lint, all 52 CI audits (including API validation), staging-base block registry checks, and generated artifact checks passed.
Checklist
Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing (new tests pass the test-audit authoring gate)
The PR appears safe to merge; no outstanding finding or new actionable issue was identified.
Summary
The PR stores accepted Trigger run IDs for immediate keyed lookup and uses the verified root run during execution cancellation. The latest changes let cancellation scans continue after a root lookup or cancellation failure and add regression coverage for those failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
bun run test:integration trigger-dev.integration.ts; report:apps/sim/test-results/integration.json. The original code failed immediate lookup and cancellation. Removing each binding, scope, active-status, and deduplication guard also failed its regression.Checklist
test-auditauthoring gate)