fix(mothership): report a browser-claimed workflow tool from its settled execution by waleedlatif1 · Pull Request #8481 · simstudioai/sim

waleedlatif1 · 2026-09-30T22:11:14Z

Summary

Problem. When the browser claims a Chat workflow tool (run_workflow and friends), a tab that closes, loses its network, or drops its pagehide beacon leaves the Chat turn waiting for the full client wait, even though the workflow itself finished.

Root cause. /api/workflows/[id]/execute takes the single-winner execution claim for the tool call and keeps running the workflow after the browser detaches. Only the browser's confirmation marked the tool call complete, though. With no confirmation, the call stayed running under the execution's claim until the worker swept it.

Fix. Once a claimed execution settles, the execute route reports its outcome. reportSettledClientWorkflowTool reads the trusted execution log, builds the same structural completion the browser would send, and records it through a new completeClientWorkflowToolCall. That write only applies while the call is still running under this execution's claim (completeClaimedAsyncToolCall). A confirmation is published only when this write wins, so a browser report or background detach that lands first is kept and the waiting turn never gets two deliveries. If the report fails, the route logs a warning and leaves the call to the existing client path.

Behaviour changes

A browser-claimed workflow tool now reaches the waiting Chat turn as soon as its execution settles, whether or not the browser is still there.
A browser report or a pagehide background detach that lands first still wins. The settled-execution report does nothing in that case.
A queued async run (async: true) is moved to the background by the route once it is queued, the same report the browser sends after the 202.
A bound execution that ended before it wrote any log is reported as failed, matching the browser's stream-error report. A paused run (non-terminal log) is still left to the client.
A call claimed by a different execution is never completed by a stray execution.
Workflows that were not claimed for a Copilot tool call run exactly as before.

Test plan

workflow-client-settlement.integration.ts against real Postgres: a completed, failed, or cancelled run reaches the waiting turn when the browser never reports; an earlier browser report is kept; a pagehide detach is kept; a stray execution cannot complete another execution's call; an execution with no log is reported failed while a paused one is left alone; a queued async run is moved to the background, and a browser report that landed first is kept
Related unit suites (app/api/workflows, lib/mothership/request/tools, lib/mothership/async-runs) pass
bun run type-check, biome, check:test-patterns, check:api-validation:strict
Staging: close the tab mid-run on a Chat run_workflow call and confirm the turn continues when the run settles

…led execution When a browser claims a Chat workflow tool, the execute route runs the workflow and keeps running it after the browser detaches, but only the browser's confirmation completed the tool call. A tab that closed, lost its network, or dropped its pagehide beacon left the Chat turn waiting for the full client wait while the worker swept the call. The execute route now records the bound execution's structural completion itself once it settles, guarded on the call still running under that execution's claim, so a browser report or background detach that lands first is kept and nothing is delivered twice.

waleedlatif1 · 2026-09-30T22:11:18Z

@greptile

waleedlatif1 · 2026-09-30T22:11:19Z

@cubic-dev-ai review this PR

vercel · 2026-09-30T22:11:21Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
docs	Ready	Preview	Sep 30, 2026 11:57pm UTC

cubic-dev-ai · 2026-09-30T22:11:25Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 5 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

cubic-dev-ai

All reported issues were addressed across 5 files

_{Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic}

greptile-apps · 2026-09-30T22:16:30Z

Confidence Score: 5/5

[Medium risk] Adds reporting of workflow tool outcomes from settled executions.

The PR appears safe to merge; no outstanding finding or new blocking issue remains.

Summary

The PR reports browser-claimed workflow tool outcomes from the settled execution, and moves queued async runs to the background without relying on a surviving browser. The latest revision extends the integration test to check Redis publication and first-report-wins behavior.

Diagram

sequenceDiagram
  participant Browser
  participant Route as Execute route
  participant DB as Execution log and tool call
  participant Chat as Chat waiter
  Browser->>Route: Claim and start workflow
  Route->>DB: Run and record execution
  alt Settled execution
    Route->>DB: Complete only under matching claim
  else Queued async run
    Route->>DB: Detach to background
  end
  DB-->>Chat: Publish winning confirmation

_{Reviews (4) · Last reviewed commit: "Merge remote-tracking branch 'origin/sta..."}

…rowser-claimed workflow tool

waleedlatif1 · 2026-09-30T22:38:22Z

@greptile

waleedlatif1 · 2026-09-30T22:38:23Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-30T22:38:29Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 6 files

_{Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic}

… log status alone

…-tool-liveness

waleedlatif1 · 2026-09-30T23:20:42Z

@greptile

waleedlatif1 · 2026-09-30T23:20:43Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-30T23:20:49Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 6 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

…rmation

…-tool-liveness

waleedlatif1 · 2026-09-30T23:55:55Z

@greptile

waleedlatif1 · 2026-09-30T23:55:56Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-30T23:56:02Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 6 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

cubic-dev-ai Bot reviewed Sep 30, 2026

View reviewed changes

Comment thread apps/sim/app/api/workflows/[id]/execute/route.ts

greptile-apps Bot reviewed Sep 30, 2026

View reviewed changes

fix(mothership): report queued async runs and pre-log failures of a b…

3b8825a

…rowser-claimed workflow tool

vercel Bot temporarily deployed to Preview September 30, 2026 22:37 Inactive

cubic-dev-ai Bot reviewed Sep 30, 2026

View reviewed changes

Comment thread apps/sim/app/api/workflows/[id]/execute/route.ts

waleedlatif1 added 2 commits September 30, 2026 16:10

refactor(mothership): settle a browser-claimed workflow tool from its…

8ae2f01

… log status alone

Merge remote-tracking branch 'origin/staging' into fix/client-claimed…

0e8e447

…-tool-liveness

vercel Bot deployed to Preview September 30, 2026 23:22 View deployment

cubic-dev-ai Bot reviewed Sep 30, 2026

View reviewed changes

waleedlatif1 added 2 commits September 30, 2026 16:45

test(mothership): prove a losing settlement report publishes no confi…

048bd3c

…rmation

Merge remote-tracking branch 'origin/staging' into fix/client-claimed…

6e9ee1b

…-tool-liveness

vercel Bot deployed to Preview September 30, 2026 23:57 View deployment

cubic-dev-ai Bot reviewed Sep 30, 2026

View reviewed changes

waleedlatif1 merged commit 21b2972 into staging Oct 1, 2026
32 checks passed

icecrasher321 mentioned this pull request Oct 1, 2026

v0.9.8: search cleanup recovery, new search providers, billing and chat reliability #8494

Merged

waleedlatif1 deleted the fix/client-claimed-tool-liveness branch October 1, 2026 01:24

Conversation

waleedlatif1 commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Behaviour changes

Test plan

Uh oh!

waleedlatif1 commented Sep 30, 2026

Uh oh!

waleedlatif1 commented Sep 30, 2026

Uh oh!

vercel Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai Bot commented Sep 30, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

greptile-apps Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Sep 30, 2026

Uh oh!

waleedlatif1 commented Sep 30, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 30, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Sep 30, 2026

Uh oh!

waleedlatif1 commented Sep 30, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 30, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Sep 30, 2026

Uh oh!

waleedlatif1 commented Sep 30, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 30, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

waleedlatif1 commented Sep 30, 2026 •

edited

Loading

vercel Bot commented Sep 30, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

greptile-apps Bot commented Sep 30, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading