Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
|
|
@AYANscyy2 is attempting to deploy a commit to the Sim Team on Vercel. A member of the Team first needs to authorize it. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #8370, addressing the second point in #8353.
When no install is found,
start/stop/restart/update/logs/downprint "No Sim install detected. Run npx sim-setup first." — which reads as "install again". It's wrong in the two common cases:statusalready says this; the lifecycle commands didn't.downand the command runs from another folder.compose lsno longer lists it, and it's only discoverable from its own directory or with--dir(viacomposeInstallFromDirectory).This adds
noInstallHint({ dockerReachable, cwd }), used byrunLifecycleand bystatus's Docker-up branch:sim/or--dir <path-to-sim>, then suggestnpx sim-setupfor new users.No detection logic changes; only the message.
Type of Change
Testing
bun run testin sim-setup passes,tsc --noEmitand Biome cleanStack down, run from another folder — before
Same — after
Docker stopped — before
Docker stopped — after
Checklist