Skip to content

fix(sim-setup): stop suggesting re-setup when no install is found - #8470

Open
AYANscyy2 wants to merge 2 commits into
simstudioai:stagingfrom
AYANscyy2:fix/setup-no-install-hint
Open

AYANscyy2 wants to merge 2 commits into
simstudioai:stagingfrom
AYANscyy2:fix/setup-no-install-hint

Conversation

@AYANscyy2

@AYANscyy2 AYANscyy2 commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #8370, addressing the second point in #8353.

When no install is found, start/stop/restart/update/logs/down print "No Sim install detected. Run npx sim-setup first." — which reads as "install again". It's wrong in the two common cases:

  1. Docker isn't running. A Compose stack is invisible, not missing. status already says this; the lifecycle commands didn't.
  2. The stack was taken down and the command runs from another folder. compose ls no longer lists it, and it's only discoverable from its own directory or with --dir (via composeInstallFromDirectory).

This adds noInstallHint({ dockerReachable, cwd }), used by runLifecycle and by status's Docker-up branch:

  • Docker down → say so, and to start Docker and re-run (no setup suggestion).
  • Docker up → name the directory searched, point existing users at the folder containing sim/ or --dir <path-to-sim>, then suggest npx sim-setup for new users.

No detection logic changes; only the message.

Type of Change

  • Bug fix

Testing

  • 2 unit tests for both branches of the hint; bun run test in sim-setup passes, tsc --noEmit and Biome clean
  • Manual, Arch Linux + Compose install:

Stack down, run from another folder — before

│
▲  No Sim install detected. Run npx sim-setup first.

Same — after

│
▲  No Sim install found from /home/ayan.
│  Docker Compose install? Run this from the folder that contains your sim/ directory, or pass --dir <path-to-sim>.
│  Kubernetes install? Check that your current kubectl context is the one Sim was installed in.
│  New here? Run npx sim-setup.

Docker stopped — before

│
▲  No Sim install detected. Run npx sim-setup first.

Docker stopped — after

│
▲  Docker is not reachable, so a Compose install cannot be detected.
│  Start Docker (Docker Desktop or OrbStack, or the docker service on Linux), then re-run this command.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 30, 2026 4:54pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

[Medium risk] Changes simulator setup status messages.

The PR should satisfy the repository’s package-manager requirement before merging.

Findings

  1. P2 Setup hint violates package-manager rule ▶

Summary

The PR replaces the generic no-install message with guidance for an unreachable Docker daemon, an undiscovered Compose directory, or a Kubernetes context mismatch.

  • The latest changes add Linux Docker-service advice and Kubernetes-specific guidance.

Reviews (2) · Last reviewed commit: "fix(sim-setup): address review feedback ..."

Comment thread packages/sim-setup/src/lifecycle.ts Outdated
Comment thread packages/sim-setup/src/lifecycle.ts Outdated
Comment thread packages/sim-setup/src/lifecycle.ts
@AYANscyy2 AYANscyy2 reopened this Sep 30, 2026
@vercel

vercel Bot commented Sep 30, 2026

Copy link
Copy Markdown

@AYANscyy2 is attempting to deploy a commit to the Sim Team on Vercel.

A member of the Team first needs to authorize it.

This branch was previously deployed

1 inactive (outdated) deployment
Preview — 551de959 Deployed Sep 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant