Skip to content

Add 80 km/h signal state and icon - #156

Merged
Julian-Louis merged 2 commits into
simrail:mainfrom
Over441:main
Sep 20, 2026
Merged

Julian-Louis merged 2 commits into
simrail:mainfrom
Over441:main

Conversation

@Over441

@Over441 Over441 commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

Add a new 80 km/h signal asset and wire it into the signal component. Creates packages/map/public/signals/signal-limited-80.png and updates packages/map/components/TrainUpcomingSignal.tsx to include "limited80" in the signalStates map and to return "limited80" from getSignalState when signalSpeed is 80, enabling rendering of 80 km/h speed-restricted signals.

Summary by CodeRabbit

  • New Features
    • Added visual support for displaying 80 km/h train signal limits on maps.

Over441 and others added 2 commits September 20, 2026 17:09
Add a new 80 km/h signal asset and wire it into the signal component. Creates packages/map/public/signals/signal-limited-80.png and updates packages/map/components/TrainUpcomingSignal.tsx to include "limited80" in the signalStates map and to return "limited80" from getSignalState when signalSpeed is 80, enabling rendering of 80 km/h speed-restricted signals.
@coderabbitai

coderabbitai Bot commented Sep 20, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 959d69dc-c4b2-4010-b2f3-a146ad4f7e0b

📥 Commits

Reviewing files that changed from the base of the PR and between 4658df1 and 87af8bf.

⛔ Files ignored due to path filters (1)
  • packages/map/public/signals/signal-limited-80.png is excluded by !**/*.png
📒 Files selected for processing (1)
  • packages/map/components/TrainUpcomingSignal.tsx

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The train signal component adds a dedicated limited80 state. An exact 80 km/h signal speed now returns this state before broader speed-limit handling.

Changes

Signal state mapping

Layer / File(s) Summary
80 km/h signal mapping
packages/map/components/TrainUpcomingSignal.tsx
The component adds the limited80 icon mapping and returns it when the signal speed is exactly 80 km/h.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding support for the 80 km/h signal state and its icon.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Julian-Louis Julian-Louis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@Julian-Louis
Julian-Louis merged commit 835672c into simrail:main Sep 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants