Repository navigation
Add 80 km/h signal state and icon - #156
Merged
Merged
Conversation
Add a new 80 km/h signal asset and wire it into the signal component. Creates packages/map/public/signals/signal-limited-80.png and updates packages/map/components/TrainUpcomingSignal.tsx to include "limited80" in the signalStates map and to return "limited80" from getSignalState when signalSpeed is 80, enabling rendering of 80 km/h speed-restricted signals.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe train signal component adds a dedicated ChangesSignal state mapping
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Feature 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new 80 km/h signal asset and wire it into the signal component. Creates packages/map/public/signals/signal-limited-80.png and updates packages/map/components/TrainUpcomingSignal.tsx to include "limited80" in the signalStates map and to return "limited80" from getSignalState when signalSpeed is 80, enabling rendering of 80 km/h speed-restricted signals.
Summary by CodeRabbit