Repository navigation
Conversation
The engine never reads ai.params.max_emotion, so the documented 1-30 range and default of 30 described a voice control customers cannot use. Keep the key so existing configs still validate, and describe it as having no effect, matching languages_enabled. Closes #823 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Collaborator
|
@Manny-r31 closing this as already covered by #852, the SWML reference alignment PR. Its commit 4709224 makes the same change: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ai.params.max_emotionas having no effect in the SWML AI params reference and the TypeSpec model.1-30range, the default of30, and the example value.Closes #823
Notes for reviewers
languages_enabledentry, which uses the same "Has no effect and can be omitted." wording.openapi.yamldiff comes from the REST tree importing the SWML models. It only touchesmax_emotion.Verification
yarn build:specssucceeds.yarn fern-md-checkpasses.Preview
/docs/swml/reference/calling/ai/params🤖 Generated with Claude Code