Skip to content

fix(swml/ai): mark max_emotion as having no effect - #864

Closed
Manny-r31 wants to merge 2 commits into
mainfrom
fix/swml-ai-max-emotion-no-effect
Closed

Manny-r31 wants to merge 2 commits into
mainfrom
fix/swml-ai-max-emotion-no-effect

Conversation

@Manny-r31

Copy link
Copy Markdown
Collaborator

Summary

  • Describe ai.params.max_emotion as having no effect in the SWML AI params reference and the TypeSpec model.
  • Remove the documented 1-30 range, the default of 30, and the example value.
  • Regenerate the SWML calling schema and the REST OpenAPI file.

Closes #823

Notes for reviewers

  • The key stays in the schema so existing SWML that sets it still validates. This follows the existing languages_enabled entry, which uses the same "Has no effect and can be omitted." wording.
  • The openapi.yaml diff comes from the REST tree importing the SWML models. It only touches max_emotion.

Verification

  • yarn build:specs succeeds.
  • yarn fern-md-check passes.
  • Confirmed the platform does not read this parameter.

Preview

  • /docs/swml/reference/calling/ai/params

🤖 Generated with Claude Code

The engine never reads ai.params.max_emotion, so the documented 1-30
range and default of 30 described a voice control customers cannot use.
Keep the key so existing configs still validate, and describe it as
having no effect, matching languages_enabled.

Closes #823

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

@Devon-White

Copy link
Copy Markdown
Collaborator

@Manny-r31 closing this as already covered by #852, the SWML reference alignment PR. Its commit 4709224 makes the same change: ai.params.max_emotion is documented as "Has no effect and can be omitted" in both ai_params.tsp and the AI params page, and the 1–30 range and default are gone. The key stays in the schema, so existing SWML still validates. I've added Closes #823 to #852 so the issue closes when it merges. Thanks for catching this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SWML AI: max_emotion is documented as a voice control but has no effect

2 participants