Repository navigation
📝 Document how to stop clients spoofing op src - #754
Open
alecgibson wants to merge 1 commit into
Open
alecgibson wants to merge 1 commit into
alecgibson wants to merge 1 commit into
Conversation
Fixes #733 At the moment, a client can submit an op with another client's `src` and next `seq`, and the server will then drop that client's real op as a duplicate, while still acking it. We can't enforce ownership of `src` in the library without a protocol change, since the handshake `id` is also chosen by the client. Instead, this change documents that `src` is client-chosen, and adds a middleware recipe that scopes it to the authenticated user. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
coverage: 97.851%. remained the same — worktree-glittery-dazzling-kahan into main |
There was a problem hiding this comment.
🟢 Approval recommended
The documentation and tests consistently implement the intended authenticated-user scoping mitigation.
0 open findings
What changed in this PR
Documents how to prevent cross-user operation-source spoofing through middleware.
Changes:
- Adds a user-scoped
srcvalidation recipe and security warnings. - Documents configurable
Agent.clientId. - Adds tests for ID assignment, reclamation, and spoof rejection.
| File | Description |
|---|---|
docs/middleware/op-submission.md |
Documents the mitigation recipe. |
docs/api/agent.md |
Documents clientId customization. |
test/middleware.js |
Tests source restriction behavior. |
lib/agent.js |
Updates the src lifecycle comment. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
alecgibson
marked this pull request as ready for review
October 13, 2026 16:15
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #733
At the moment, a client can submit an op with another client's
srcand nextseq, and the server will then drop that client's real op as a duplicate, while still acking it.We can't enforce ownership of
srcin the library without a protocol change, since the handshakeidis also chosen by the client. Instead, this change documents thatsrcis client-chosen, and adds a middleware recipe that scopes it to the authenticated user.🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com