Repository navigation
π·ββοΈ Point CI and README badges at main - #45
Merged
Merged
Conversation
The repository's default branch has been renamed from `master` to `main`. GitHub moves the branch, the default-branch setting and any open pull requests for us, but it leaves the contents of the repository alone, so anything in-tree naming the old branch now points at a ref that doesn't exist. Two things break. The `Test` workflow filters both its `push` and `pull_request` triggers on `master`, so CI would silently stop running altogether β no failures, just no runs. The Coveralls badge pins `?branch=master`, so it would render "unknown" indefinitely. This change points both at `main`. The Coveralls badge will still read "unknown" until the first build lands on `main`, since Coveralls files coverage per branch name and all our history sits under `master`. While in the badge block, the dead Travis badge is replaced with a GitHub Actions one for the `Test` workflow, since Travis hasn't run this repository since it moved to Actions. That badge deliberately omits a `?branch=` parameter: GitHub's workflow badges default to the repository's default branch, so it survives any future rename for free. The NPM badge also linked to `sharedb-mingo-mongo`, which isn't a published package; it now links to `sharedb-mingo-memory`. Finally, `coverallsapp/github-action` is pinned to `v2.3.8`. It was tracking that action's `master` branch, and upstream has been through this same rename: their default is `main` now, and the abandoned `master` branch has sat at April 2023 ever since. So we were tracking a three-year-old action by accident, and invisibly β Dependabot's `github-actions` updates bump tags and SHAs, not branch refs. π€ Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repository's default branch has been renamed from
mastertomain. GitHub moves the branch, the default-branch setting and any open pull requests for us, but it leaves the contents of the repository alone, so anything in-tree naming the old branch now points at a ref that doesn't exist.Two things break. The
Testworkflow filters both itspushandpull_requesttriggers onmaster, so CI would silently stop running altogether β no failures, just no runs. The Coveralls badge pins?branch=master, so it would render "unknown" indefinitely. This change points both atmain. The Coveralls badge will still read "unknown" until the first build lands onmain, since Coveralls files coverage per branch name and all our history sits undermaster.While in the badge block, the dead Travis badge is replaced with a GitHub Actions one for the
Testworkflow, since Travis hasn't run this repository since it moved to Actions. That badge deliberately omits a?branch=parameter: GitHub's workflow badges default to the repository's default branch, so it survives any future rename for free. The NPM badge also linked tosharedb-mingo-mongo, which isn't a published package; it now links tosharedb-mingo-memory.Finally,
coverallsapp/github-actionis pinned tov2.3.8. It was tracking that action'smasterbranch, and upstream has been through this same rename: their default ismainnow, and the abandonedmasterbranch has sat at April 2023 ever since. So we were tracking a three-year-old action by accident, and invisibly β Dependabot'sgithub-actionsupdates bump tags and SHAs, not branch refs.π€ Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com