Conversation
OFL-Inter.txt carried the copyright line from the Google Fonts copy (2020). The font file (name ID 0) and rsms/inter's LICENSE.txt both say "Copyright (c) 2016 The Inter Project Authors", so ship the upstream file, as in the ros2_medkit docs. Inter reserves no font name, so the bundled Latin subset is fine under the OFL; OFL-Oxanium.txt already matches upstream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
profile/design/fonts/OFL-Inter.txtcarried the copyright line from the Google Fonts copy of the licence ("Copyright 2020 The Inter Project Authors"). The bundled font itself (name ID 0) and the upstreamLICENSE.txtin rsms/inter both say "Copyright (c) 2016 The Inter Project Authors". This replaces the file with the upstream one, so the licence and the font match.Bartosz spotted the same mismatch in review of selfpatch/ros2_medkit#715, which bundles the same Inter file and is fixed the same way there.
Checked
inter-latin.woff2) may keep its name under the OFL.OFL-Oxanium.txtalready matches upstream (sevmeyer/oxanium) apart from whitespace.Licence text only: no image or font changes, and nothing needs re-rendering.