Repository navigation
perf: use indexed lookups in mandatory tests 6.1.1 and 6.1.3 - #858
Merged
bendo-eXX merged 1 commit intoOct 26, 2026
Merged
Conversation
1 similar comment
|
Coverage after merging perf/indexed-product-id-lookups into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
bendo-eXX
self-requested a review
October 26, 2026 09:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
perf: use indexed lookups in mandatory tests 6.1.1 and 6.1.3
Fixes secvisogram/csaf-validator-service#281
findMissingDefinitions(6.1.1, shared docUtils, CSAF 2.1 docProductUtils) and thecycle search in 6.1.3 used linear
find/some/findIndexlookups inside loops,which is quadratic in the number of products. This PR replaces them with a
Setof defined ids and a
Mapfrom product id to the first relationship index(same semantics as the former
findIndex). The CSAF 2.1 variant of 6.1.1 alreadyuses a
Set.Results on cve-2023-39325.json (Red Hat VEX, 76 MB), released 3.0.0 vs. this branch:
Results were also identical after injecting a missing product reference and a
relationship cycle into the document.
npm test(node project): all tests pass except the 6.3.8 OASIS tests, which alsofail on
mainlocally becausehunspellis not installed.