Repository navigation
docs: channel, IRQ and I/O port ids are less than 62 - #623
Shakhtar-Sankur wants to merge 1 commit into
Conversation
The tool rejects any irq, ioport or channel end id above PD_MAX_ID (61), with "id must be < 62", and libmicrokit has MICROKIT_MAX_CHANNELS = 62. The manual said these ids must be less than 63, and that a PD supports up to 63 channels and interrupts, so a system written to the manual could fail to build. The vCPU id entry already said less than 62. Reported in seL4#596. Signed-off-by: Sankur Kundu <sankur.kundu.tw@gmail.com>
|
Was this written by AI? Based on the text in this issue, plus your contribution history (30+ PRs to 30+ projects in November so far) I suspect it is. |
|
Hi @midnightveil, fair question. Yes, I use AI tools in my work, including for drafting this PR. I'm responsible for what I submit: before opening it I checked the limit against the code (PD_MAX_ID = 61 in tool/microkit/src/sdf/consts.rs, MICROKIT_MAX_CHANNELS = 62 in libmicrokit) and that the existing tool tests already expect "id must be < 62". On the history: this account is new, since my earlier one was deleted, and I've been working through small, testable fixes across projects, which is why the count looks high. If seL4 would rather not take AI-assisted contributions, that's completely fine. I'm happy to close this and leave #596 to you. |
Fixes #596.
Why: the tool rejects an
irq,ioportor channelendid abovePD_MAX_ID(61) withid must be < 62(tool/microkit/src/sdf/consts.rs,pd_vm.rs,channels.rs), andlibmicrokitdefinesMICROKIT_MAX_CHANNELSas 62. The manual said these ids must be less than 63 and that a protection domain supports up to 63 channels and interrupts, so a system description written from the manual can fail to build with id 62. The other two points in #596 (triggerandpolarity) are already correct in the current manual.How: the five id descriptions now say "less than 62", and the per-PD maximum says 62 channels and interrupts. The vCPU id (already "less than 62") and the 63 protection-domain limit (
MAX_PDS) are unchanged.Testing: documentation only. The limits match the existing tool tests in
tool/microkit/tests/test.rs, which expectid must be < 62forirqandend.