Repository navigation
Conversation
Fixes scop#1370 $1 can be a user alias, which is not expanded when used as a command name through a parameter expansion. Query the real command instead so that aliases produce the same options.
Collaborator
|
Allowing the user to define the completion for There is a reason that we use In addition, even if we should fix this, the fix shouldn't be applied to each command separately in each PR. The change should be applied consistently to all similar completion settings. |
Author
|
Now I know. Thank you for your reply. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1370
$1 can be a user alias, which is not expanded when used as a command name through a parameter expansion. Query the real command instead so that aliases produce the same options.