Repository navigation
fix: guard scheduler daemon ownership and bound test waits - #513
Merged
Merged
Conversation
The daemon lifecycle test waited without a deadline while checking duplicate startup and shutdown, so CI could hang without identifying the stuck phase. Heartbeat reads cannot arbitrate ownership: an in-place write can look like an absent daemon, and two starters can both observe no owner. A lifetime lock is needed even when the heartbeat is missing or stale.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The daemon lifecycle test waited without a deadline while checking duplicate
startup and shutdown, so CI could hang without identifying the stuck phase.
Heartbeat reads cannot arbitrate ownership: an in-place write can look like an
absent daemon, and two starters can both observe no owner. A lifetime lock is
needed even when the heartbeat is missing or stale.