Repository navigation
fix: stop scode-shepherd plans forbidding the worker's report - #511
Merged
Merged
Conversation
The scode-shepherd skill told the supervisor that workers never write in the run directory. That is false: the runner has every worker session write its report file there, and the skill's spec says that report is the only thing a worker writes there. On a real run the supervisor copied the false sentence into the plan as a rule for every worker, "Never write files in the run directory yourself", which contradicts the runner's own instruction to write the report. For a plan rule that conflicts with one of its own, the runner tells the worker to follow the runner's rule and report replan, which stops the run and wakes the supervisor to fix the plan. That worker wrote its report and carried on, but a worker that followed the precedence rule could halt the run over this one sentence. The skill now says what is true: a worker writes only its own report in the run directory. The supervisor must not tell a worker to write anything else there, which is what the old sentence was for (workers logging decisions in the run's journal, which the runner fills from their reports), and must not ban writes there altogether either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scode-shepherd skill told the supervisor that workers never write in the run directory. That is false: the runner
has every worker session write its report file there, and the skill's spec says that report is the only thing a worker
writes there. On a real run the supervisor copied the false sentence into the plan as a rule for every worker, "Never
write files in the run directory yourself", which contradicts the runner's own instruction to write the report. For a
plan rule that conflicts with one of its own, the runner tells the worker to follow the runner's rule and report
replan, which stops the run and wakes the supervisor to fix the plan. That worker wrote its report and carried on, but
a worker that followed the precedence rule could halt the run over this one sentence.
The skill now says what is true: a worker writes only its own report in the run directory. The supervisor must not tell
a worker to write anything else there, which is what the old sentence was for (workers logging decisions in the run's
journal, which the runner fills from their reports), and must not ban writes there altogether either.