Skip to content

fix: stop scode-shepherd workers commissioning their own PR reviews - #509

Merged
scode merged 1 commit into
mainfrom
shepherd-no-worker-review
Nov 7, 2026
Merged

scode merged 1 commit into
mainfrom
shepherd-no-worker-review

Conversation

@scode

@scode scode commented Nov 7, 2026

Copy link
Copy Markdown
Owner

scode-shepherd's runner has a strong reviewer model review every PR a worker model reports done. When the run comes
from a scode-build-goal goal file, the goal the worker reads includes the user's choice of reviewer ("one
fresh-context gpt-6.1-sol high reviewer per PR"). On a real run two worker sessions took that as their own job: they
had a sol reviewer look at their diff before reporting done, and wrote "independent gpt-6.1-sol high review reported
no findings" into their reports. The runner then ran the same review again. That paid for a strong-model review twice,
and the worker's report claimed a review that the worker had set up and summarized itself, which reads like the
user's review gate passing when it had not run yet.

The worker is now told that the runner's review is the one the goal asks for, and not to have another model or agent
review the PR itself. Review steps the repository asks of every author, such as having a fresh reader check commit
messages, still apply. The plan the supervisor writes for the run keeps the goal text verbatim, so the fix is in the
runner's own instructions to the worker rather than in an edited copy of the goal.

@scode
scode force-pushed the shepherd-interface-sketches branch from 21d3ffc to 4930968 Compare November 7, 2026 14:10
Base automatically changed from shepherd-interface-sketches to main November 7, 2026 14:11
scode-shepherd's runner has a strong reviewer model review every PR a worker model reports done. When the run comes
from a scode-build-goal goal file, the goal the worker reads includes the user's choice of reviewer ("one
fresh-context gpt-6.1-sol high reviewer per PR"). On a real run two worker sessions took that as their own job: they
had a sol reviewer look at their diff before reporting done, and wrote "independent gpt-6.1-sol high review reported
no findings" into their reports. The runner then ran the same review again. That paid for a strong-model review twice,
and the worker's report claimed a review that the worker had set up and summarized itself, which reads like the
user's review gate passing when it had not run yet.

The worker is now told that the runner's review is the one the goal asks for, and not to have another model or agent
review the PR itself. Review steps the repository asks of every author, such as having a fresh reader check commit
messages, still apply. The plan the supervisor writes for the run keeps the goal text verbatim, so the fix is in the
runner's own instructions to the worker rather than in an edited copy of the goal.
@scode
scode force-pushed the shepherd-no-worker-review branch from 5227a17 to be66eb9 Compare November 7, 2026 14:12
@scode
scode marked this pull request as ready for review November 7, 2026 14:12
@scode
scode merged commit 27afb80 into main Nov 7, 2026
5 checks passed
@scode
scode deleted the shepherd-no-worker-review branch November 7, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant