Repository navigation
ADR 0013: Follow adds the rows that a batch has not considered - #238
Merged
Merged
Conversation
Proposed, on top of ADR 0012. A batch made from a source keeps the name of the source and the keys it has considered. A step of Follow adds the rows of the source whose keys are not among them, once the source has filled the columns it fills, and changes no row that the table has. So a row that a person removed stays away without a mark in the table, and a restart adds the rows that arrived in between. No scope is kept: its start is the choice of rows at making, and its end is "Start the next batch here", which moves the source to the next batch. A step reduces the ready rows without a record. ADR 0012 and ADR 0011 point to it for the parts it decides or replaces. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADR 0013, proposed: Follow adds the rows that a batch has not considered. A decision to review; no code. On top of #237 (ADR 0012), which left open how a batch is amended from the files. Part of #236.
The decision proposed
A batch made from a source keeps the name of the source and the keys it has considered, next to its table. A step of Follow adds the rows of the source whose keys are not among them, once the source has filled them, and changes no row that the table has.
consideredis kept.What it gives up
What goes when it is built
Scope,Row.index,Source.index_type,Header.scope,Header.source,manager.change(scope=...),RowState.changed_by_hand, and the columnsatofAutomatic: most of #229 and part of #235.To decide in review
Nonewould let a row through before its file is listed ("Alternatives considered").🤖 Generated with Claude Code