Repository navigation
Description
ADR 0011 is accepted (#220). This issue tracks its implementation in ess.apps.batch and the batch page.
Parts
Each part is usable alone, in the order the ADR gives:
- 1. Header, manager, one loop of Follow.
header.jsonper label; the definitions list their labels and delete a part;BatchManager(create,batches,counts,batch,edit,remove) for batches made in code; oneFollowloop per application, kept indefinitions/following.json; a page per batch at/batches/<label>/, with the list of batches. Pull requests: The definitions list their labels, delete a table, and keep a header #225, BatchManager, registered sources, and one loop of Follow #226, A page per batch by URL; Follow is one loop of the application #227, The list of batches in the page, and the counts #228. - 2. Index of a row, and scope. A source gives each row an index; a batch has a scope (
start/stopof index values, or keys) that its scan applies and that can be set. Pull request: The index of a row, and the scope of a batch #229. - 3. Making, changing and removing a batch from the page, with the sources and first settings that an application registers; "Start the next batch here";
essapps-batch reduce --labelreads and writes the header. Pull requests: Make a batch from the page #232 (make), Change, end and remove a batch from the page #233 (change, end, remove), The command and the page work on the same batches #234 (the command). - Consolidation after a review of the concepts: the header holds the name of the spec and the columns (ADR 0011 amended);
headers(),change(),Source.fills;Batchtakes itsSourcewhole. Pull requests: Consolidate: the header says what a batch is; names that say one thing each #230, Consolidate: Batch takes its Source whole #231. - Second consolidation after two adversarial reviews of the whole stack: the manager keeps which batch follows; "Start the next batch here" is the manager's and leaves Follow where it is; a scope is a slice; a refusal of the manager is a
ValueError; only the manager gives aBatchits definitions. ADR 0011 amended. Pull request: Consolidate after two adversarial reviews: the manager owns the rules and which batch follows #235.
All parts are merged. ADR 0012 and ADR 0013 (#236) replace the scope of part 2, the spec and columns in the header, and edits.json.
Where the list of batches goes in the page
The page has two views in its header, "Rows" and "Runs". The list of batches becomes a third, "Batches". "Batches" and "Runs" belong to the workspace and are the same from every batch; "Rows" is the batch named in the URL. The header of that batch (title, description, scope, remove) is a tab next to "Settings".
[ Batches 4 | Rows 37 | Runs 212 ] Files ▾
┌ Batches ────────────────────────────────────────────┐ ┌ Result | Settings | Row | Batch ┐
│ batch scope rows status follow │ │ title, description, scope │
│ Morning 60301–60339 38 38 │ │ [Start the next batch here] │
│ Afternoon, 2 mm 60339– 12 9 ● │ │ [Remove] │
│ + New batch │ └─────────────────────────────────┘
A sidebar was considered: it takes width from the table and the plot, which already share the window. A separate page was considered: a person would leave the batch to see whether another one has rows to reduce.
Not part of this
- Several workflows on one batch: Batch: several workflows on one batch, each adding its outputs as columns #222.
- What users need: Ask instrument scientists how reductions are organised during an experiment #221.
- Cost of a batch without an end: Batch page: the cost of a batch without an end, and showing only its newest rows #223.
- The points under "Open" in the ADR. Those that the implementation settles are noted here.
Part of #162.
Activity