Skip to content

[ESSREDUCE] Apply TransformationOverrides to chopper positions - #890

Open
SimonHeybrock wants to merge 1 commit into
mainfrom
chopper-transformation-overrides
Open

SimonHeybrock wants to merge 1 commit into
mainfrom
chopper-transformation-overrides

Conversation

@SimonHeybrock

@SimonHeybrock SimonHeybrock commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

The recent #858 added TransformationOverrides (see there for more context). It turned out that this was incomplete:

TransformationOverrides did not reach choppers: parse_raw_choppers computed positions from the depends_on chain stored in each NXdisk_chopper group. It now reads NeXusMultiTransformationChain[NXdisk_chopper, RunType], which has the overrides applied, so a chopper on a motorised stage can take its position from a streamed value like any other component.

Motivation: in esslivedata the wavelength lookup table is built from a geometry artifact in which motor-driven transforms are length-0 placeholders, filled from Kafka through TransformationOverrides. ODIN's WFM choppers sit on a linear stage (see #856), so their chains have such a placeholder. Without this change esslivedata has to cut the chain in the artifact and pin the choppers at motor position 0.

With no overrides set, positions are unchanged.

🤖 Generated with Claude Code

parse_raw_choppers computed positions from the depends_on chain stored in
each NXdisk_chopper group, so overrides never reached choppers. It now
takes NeXusMultiTransformationChain[NXdisk_chopper, RunType], which has the
overrides applied, and uses those chains in place of the stored ones.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@SimonHeybrock SimonHeybrock self-assigned this Nov 19, 2026
@github-actions github-actions Bot added the essreduce Issues for essreduce. label Nov 19, 2026
@github-actions github-actions Bot changed the title Apply TransformationOverrides to chopper positions [ESSREDUCE] Apply TransformationOverrides to chopper positions Nov 19, 2026
SimonHeybrock added a commit to scipp/esslivedata that referenced this pull request Nov 19, 2026
The chains are pinned because essreduce does not apply
TransformationOverrides to choppers (scipp/ess#890) and both positioners
share one PV, not because the generator trims the NXlog: trimming to a
placeholder is how live transforms are meant to work.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

essreduce Issues for essreduce.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant