Repository navigation
Conversation
Contributor
Hello delthas,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development/9.4 #6326 +/- ##
================================================
Coverage 86.47% 86.47%
================================================
Files 212 212
Lines 14569 14569
================================================
Hits 12598 12598
Misses 1971 1971
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
The guard previously required ./lib/Config to decide whether to skip tracing.init() on the cluster primary. Config top-level-requires arsenal, which eagerly loads mongodb and ioredis clients. By the time tracing.init() ran, those modules were already in require.cache, so require-in-the-middle hooks installed by MongoDBInstrumentation and IORedisInstrumentation never patched them and spans silently never emerged (HTTP spans worked because HttpInstrumentation patches the Node core modules directly). Drop the primary-skip entirely and initialize unconditionally when ENABLE_OTEL=true. The cluster primary now boots a BatchSpanProcessor that has nothing to export; the fixed, bounded cost is accepted in exchange for correct auto-instrumentation on workers. Issue: CLDSRV-1023
delthas
force-pushed
the
bugfix/CLDSRV-1023/fix-otel-init-order
branch
from
October 13, 2026 14:50
22a6170 to
59f4d65
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix OTEL auto-instrumentation per CLDSRV-1023.
The guard in
index.jsrequired./lib/Configto decide whether to skip init on the cluster primary, which transitively loaded mongodb (260 modules) and ioredis (108 modules) via arsenal's barrel beforetracing.init()ran — soMongoDBInstrumentationandIORedisInstrumentationnever patched them.Drop the primary-skip, initialize unconditionally when
ENABLE_OTEL=true. Primary now boots an idle SDK (bounded cost: one BatchSpanProcessor + exporter connection).Issue: CLDSRV-1023