Repository navigation
Conversation
Hello tmacro,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
|
/create_integration_branches |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following options are set: create_integration_branches |
| `RequestsPerSecond (${limit}) must be >= nodes (${nodes}) or 0 (unlimited). ` + | ||
| 'Each node enforces limit/nodes locally. ' + | ||
| `With limit < ${nodes}, per-node rate would be < 1 req/s, effectively blocking traffic.` |
There was a problem hiding this comment.
If we are using only nodes, as we run 10 processes per node, does that mean we will have 10x the limit allowed on a node?
I don't get it, i thought we are using nodes * workers as we are dividing the node limit among workers on that node and thats the reason for the limit to be atleast higher than nodes* workers. Has something changed?
Example: lets say there are 6 nodes, and we have 10 workers per node, how will 1 req/s be divided among 10 workers
Fix mismatched check in PutBucketRateLimit. The check enforced
limit >= nodes * workerswhere the config check (correctly) enforcedlimit >= nodes.