Skip to content

impr(CLDSRV-1024): Fix mismatched min rate limit check - #6325

Open
tmacro wants to merge 2 commits into
development/9.2from
bugfix/CLDSRV-1024-fix-min-ratelimit-check
Open

tmacro wants to merge 2 commits into
development/9.2from
bugfix/CLDSRV-1024-fix-min-ratelimit-check

Conversation

@tmacro

@tmacro tmacro commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Fix mismatched check in PutBucketRateLimit. The check enforced limit >= nodes * workers where the config check (correctly) enforced limit >= nodes.

@bert-e

bert-e commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Hello tmacro,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/bypass_source_branch_lineage Bypass the cross-branch contamination check ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request.
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@codecov

codecov Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
8145 1 8144 0
View the top 1 failed test(s) by shortest run time
should reject limits less than nodes::Test put bucket rate limit validation against node count should reject limits less than nodes
Stack Traces | 0.003s run time
Cannot read properties of undefined (reading 'Code')

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@scality scality deleted a comment from bert-e Oct 12, 2026
@bert-e

bert-e commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@tmacro

tmacro commented Oct 12, 2026

Copy link
Copy Markdown
Contributor Author

/create_integration_branches

@scality scality deleted a comment from bert-e Oct 12, 2026
@bert-e

bert-e commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_integration_branches

Comment on lines +33 to +35
`RequestsPerSecond (${limit}) must be >= nodes (${nodes}) or 0 (unlimited). ` +
'Each node enforces limit/nodes locally. ' +
`With limit < ${nodes}, per-node rate would be < 1 req/s, effectively blocking traffic.`

@anurag4DSB anurag4DSB Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are using only nodes, as we run 10 processes per node, does that mean we will have 10x the limit allowed on a node?
I don't get it, i thought we are using nodes * workers as we are dividing the node limit among workers on that node and thats the reason for the limit to be atleast higher than nodes* workers. Has something changed?

Example: lets say there are 6 nodes, and we have 10 workers per node, how will 1 req/s be divided among 10 workers

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants