Repository navigation
Drop the AWS SDK v2 maintenance-message suppression - #2890
Conversation
Move off the 8.6.0 preview to the final release. Arsenal 8.6.0 moves its OpenTelemetry SDK to 0.223, so bump the instrumentations we hand to it alongside, to keep a single copy of the OTel instrumentation packages in the image. Issue: BB-883
The release depends on the released arsenal 8.6.0, so the dev tree no longer carries a second copy of the 8.6.0 preview. Issue: BB-883
Arsenal already pulls 2.12.0, so the devDependency resolves to it too. Issue: BB-883
cloudserver 9.5.0 no longer brings request or oas-tools into the dev tree, so these overrides match nothing and only left orphaned entries in the lockfile. Issue: BB-883
Nothing in the production dependency tree pulls aws-sdk v2 anymore, so the variable silencing its maintenance-mode notice is no longer needed. Issue: BB-883
Hello francoisferrand,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
@@ Coverage Diff @@
## development/9.6 #2890 +/- ##
===================================================
- Coverage 81.41% 81.24% -0.17%
===================================================
Files 209 209
Lines 44290 44290
===================================================
- Hits 36057 35985 -72
- Misses 8233 8305 +72
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
/approve |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
This pull request did not target the following hotfix branch(es) so they
Please check the status of the associated issue BB-883. Goodbye francoisferrand. The following options are set: approve |
We were silencing the AWS SDK v2 maintenance notice in the image because v2 still came in through bucketclient's arsenal. Now that our whole dependency tree runs on SDK v3, the image no longer contains v2 at all, so the workaround can go.
This also moves arsenal from the 8.6.0 preview to the actual release, and bumps cloudserver (used in tests) to 9.5.0, which is built on the same arsenal. That lets us drop a few dependency overrides that only existed to patch packages cloudserver no longer pulls in.
Issue: BB-883